| Message ID | 20170929203839.7010-13-andi@etezian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Sat, Sep 30, 2017 at 05:38:39AM +0900, Andi Shyti wrote: > Commit 57b8ff070f98 ("driver core: add devm_device_add_group() > and friends") has added the the managed version for creating > sysfs group files. > > Use devm_device_add_group instead of sysfs_create_group and > remove the relative sysfs_remove_group. > > Signed-off-by: Andi Shyti <andi@etezian.org> Applied, thank you. > --- > drivers/input/touchscreen/wdt87xx_i2c.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c b/drivers/input/touchscreen/wdt87xx_i2c.c > index a9132603ab34..b866cc88d942 100644 > --- a/drivers/input/touchscreen/wdt87xx_i2c.c > +++ b/drivers/input/touchscreen/wdt87xx_i2c.c > @@ -1106,7 +1106,7 @@ static int wdt87xx_ts_probe(struct i2c_client *client, > return error; > } > > - error = sysfs_create_group(&client->dev.kobj, &wdt87xx_attr_group); > + error = devm_device_add_group(&client->dev, &wdt87xx_attr_group); > if (error) { > dev_err(&client->dev, "create sysfs failed: %d\n", error); > return error; > @@ -1117,8 +1117,6 @@ static int wdt87xx_ts_probe(struct i2c_client *client, > > static int wdt87xx_ts_remove(struct i2c_client *client) > { > - sysfs_remove_group(&client->dev.kobj, &wdt87xx_attr_group); > - > return 0; > } > > -- > 2.14.2 >
diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c b/drivers/input/touchscreen/wdt87xx_i2c.c index a9132603ab34..b866cc88d942 100644 --- a/drivers/input/touchscreen/wdt87xx_i2c.c +++ b/drivers/input/touchscreen/wdt87xx_i2c.c @@ -1106,7 +1106,7 @@ static int wdt87xx_ts_probe(struct i2c_client *client, return error; } - error = sysfs_create_group(&client->dev.kobj, &wdt87xx_attr_group); + error = devm_device_add_group(&client->dev, &wdt87xx_attr_group); if (error) { dev_err(&client->dev, "create sysfs failed: %d\n", error); return error; @@ -1117,8 +1117,6 @@ static int wdt87xx_ts_probe(struct i2c_client *client, static int wdt87xx_ts_remove(struct i2c_client *client) { - sysfs_remove_group(&client->dev.kobj, &wdt87xx_attr_group); - return 0; }
Commit 57b8ff070f98 ("driver core: add devm_device_add_group() and friends") has added the the managed version for creating sysfs group files. Use devm_device_add_group instead of sysfs_create_group and remove the relative sysfs_remove_group. Signed-off-by: Andi Shyti <andi@etezian.org> --- drivers/input/touchscreen/wdt87xx_i2c.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)