From patchwork Fri Oct 6 01:16:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masaki Ota <012nexus@gmail.com> X-Patchwork-Id: 9988195 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8F5C260216 for ; Fri, 6 Oct 2017 01:17:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 81B1328CCF for ; Fri, 6 Oct 2017 01:17:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7688C28D44; Fri, 6 Oct 2017 01:17:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,FROM_STARTS_WITH_NUMS,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 15F8428CCF for ; Fri, 6 Oct 2017 01:17:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751757AbdJFBRX (ORCPT ); Thu, 5 Oct 2017 21:17:23 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34980 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbdJFBRV (ORCPT ); Thu, 5 Oct 2017 21:17:21 -0400 Received: by mail-pg0-f65.google.com with SMTP id p5so14590694pgn.2; Thu, 05 Oct 2017 18:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KHfno1sUpBhzTRmrX1vmSeWo5AIqD39yn25myL3AA+Q=; b=ieMsF96l4WmMRTYAWz6d0eTcte/BqqM2/QDjkcnjcFg10bSrL64TQTSnONrLc+keec dVILBAIzOvWZsjPnFeOH+xaJgmDlFrq0V8zuC3ft7iscon3DCPnPVebv7Gn30JAe0d5F u4A9J8Of/L9r99PMhJQUK5n5i6CcUCYF74JwpSafIC8jSqxEHX5hiwHAMghsiUFcBzga 83Tmp8nY2bluh9f6C9VRWKMngRHiJYPMUd0SufUk52E5BesVEkvQ6c6gMlNTL8l/N3zC ayCwPfJ1f4eKn4Gv1qCjjUHaaDlHeaeN3meNAr4lMu1A4eKenfc+RycLMd2rPk6yaFT6 GUkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KHfno1sUpBhzTRmrX1vmSeWo5AIqD39yn25myL3AA+Q=; b=nHttUMgxe3JkFJzF7hN8RFTyOhhW0gWtlorNdvXdV2LsbESRKUQkvYwWGMhGjUAktI 0E969NZ228bt16gPirdh89kUK6efpmW44JdjKYGMzcuJjB6cLYE4ley8NBF3Sr1WQ5/g Un7NotKwqOq3Qv8CjNqHqQqLSbhiMAciHde+hnjk6boh8jw72CJ+oshYKiWazbjUuK3y mhnKtWcDqaSMyNAN+cLlsyfSzPy5CQaeFDP3c9GLujIRjkV64+Ko3peQS2IGLeeNy75m 8Fp6ESUWIL2X6fbG3PYmlfU6CpQhhAoHWvtDCcTG4e5sSo8rDJtjLK2hvM9H8SPIxY6n xndA== X-Gm-Message-State: AMCzsaUic+RqO+G/Cy2PQS9mLhc1/HZ/MQ/1wkLE59pOxMeQb+db7v2j K7RbVRqfmzKBCwyMTLqJDvE= X-Google-Smtp-Source: AOwi7QBNNhF6KjAHVQBpNg9nB8qmqXmSm2tCk2ZIJjGhLuVX1rXqCcEATzSYW91ZbmaO3gXhF/Sy9A== X-Received: by 10.101.81.137 with SMTP id h9mr458027pgq.347.1507252641079; Thu, 05 Oct 2017 18:17:21 -0700 (PDT) Received: from localhost (p2218-ipad303aobadori.miyagi.ocn.ne.jp. [123.216.73.218]) by smtp.gmail.com with ESMTPSA id c16sm330090pfj.123.2017.10.05.18.17.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2017 18:17:20 -0700 (PDT) From: Masaki Ota <012nexus@gmail.com> X-Google-Original-From: Masaki Ota To: jikos@kernel.org, benjamin.tissoires@redhat.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, masaki.ota@jp.alps.com Subject: [PATCH 3/7] Add some variables Date: Fri, 6 Oct 2017 10:16:57 +0900 Message-Id: <20171006011701.3761-4-masaki.ota@jp.alps.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171006011701.3761-1-masaki.ota@jp.alps.com> References: <20171006011701.3761-1-masaki.ota@jp.alps.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Masaki Ota -Create x_min, y_min and max_fingers variables for set correct XY minimum value and the number of max finger on each devices. -Move the Button pad checking code to U1 init function, because this checking code is for U1 device. Signed-off-by: Masaki Ota --- drivers/hid/hid-alps.c | 38 ++++++++++++++++++++++++-------------- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index c4ea5c6c9be9..201fe175cba3 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -73,9 +73,12 @@ * @y_active_len_mm: active area length of Y (mm) * @x_max: maximum x coordinate value * @y_max: maximum y coordinate value + * @x_min: minimum x coordinate value + * @y_min: minimum y coordinate value * @btn_cnt: number of buttons * @sp_btn_cnt: number of stick buttons * @has_sp: boolean of sp existense + * @max_fingers: total number of fingers */ struct u1_dev { struct input_dev *input; @@ -95,9 +98,12 @@ struct u1_dev { u32 y_active_len_mm; u32 x_max; u32 y_max; + u32 x_min; + u32 y_min; u32 btn_cnt; u32 sp_btn_cnt; u8 has_sp; + u8 max_fingers; }; static int u1_read_write_register(struct hid_device *hdev, u32 address, @@ -319,8 +325,10 @@ static int u1_init(struct hid_device *hdev, struct u1_dev *pri_data) pri_data->x_max = (pri_data->resolution << 2) * (pri_data->sen_line_num_x - 1); + pri_data->x_min = 1; pri_data->y_max = (pri_data->resolution << 2) * (pri_data->sen_line_num_y - 1); + pri_data->y_min = 1; ret = u1_read_write_register(hdev, ADDRESS_U1_PAD_BTN, &pri_data->btn_info, 0, true); @@ -328,6 +336,12 @@ static int u1_init(struct hid_device *hdev, struct u1_dev *pri_data) dev_err(&hdev->dev, "failed U1_PAD_BTN (%d)\n", ret); goto exit; } + if ((pri_data->btn_info & 0x0F) == (pri_data->btn_info & 0xF0) >> 4) { + pri_data->btn_cnt = (pri_data->btn_info & 0x0F); + } else { + /* Button pad */ + pri_data->btn_cnt = 1; + } pri_data->has_sp = 0; /* Check StickPointer device */ @@ -355,7 +369,7 @@ static int u1_init(struct hid_device *hdev, struct u1_dev *pri_data) } pri_data->has_sp = 1; } - + pri_data->max_fingers = 5; exit: return ret; } @@ -383,8 +397,10 @@ static int alps_input_configured(struct hid_device *hdev, struct hid_input *hi) goto exit; __set_bit(EV_ABS, input->evbit); - input_set_abs_params(input, ABS_MT_POSITION_X, 1, data->x_max, 0, 0); - input_set_abs_params(input, ABS_MT_POSITION_Y, 1, data->y_max, 0, 0); + input_set_abs_params(input, ABS_MT_POSITION_X, + data->x_min, data->x_max, 0, 0); + input_set_abs_params(input, ABS_MT_POSITION_Y, + data->y_min, data->y_max, 0, 0); if (data->x_active_len_mm && data->y_active_len_mm) { res_x = (data->x_max - 1) / data->x_active_len_mm; @@ -396,26 +412,21 @@ static int alps_input_configured(struct hid_device *hdev, struct hid_input *hi) input_set_abs_params(input, ABS_MT_PRESSURE, 0, 64, 0, 0); - input_mt_init_slots(input, MAX_TOUCHES, INPUT_MT_POINTER); + input_mt_init_slots(input, data->max_fingers, INPUT_MT_POINTER); __set_bit(EV_KEY, input->evbit); - if ((data->btn_info & 0x0F) == (data->btn_info & 0xF0) >> 4) { - data->btn_cnt = (data->btn_info & 0x0F); - } else { - /* Button pad */ - data->btn_cnt = 1; + + if (data->btn_cnt == 1) __set_bit(INPUT_PROP_BUTTONPAD, input->propbit); - } for (i = 0; i < data->btn_cnt; i++) __set_bit(BTN_LEFT + i, input->keybit); - /* Stick device initialization */ if (data->has_sp) { input2 = input_allocate_device(); if (!input2) { - ret = -ENOMEM; + input_free_device(input2); goto exit; } @@ -439,8 +450,7 @@ static int alps_input_configured(struct hid_device *hdev, struct hid_input *hi) __set_bit(INPUT_PROP_POINTER, input2->propbit); __set_bit(INPUT_PROP_POINTING_STICK, input2->propbit); - ret = input_register_device(data->input2); - if (ret) { + if (input_register_device(data->input2)) { input_free_device(input2); goto exit; }