From patchwork Sun Nov 26 04:34:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Axtens X-Patchwork-Id: 10075231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1687D60353 for ; Sun, 26 Nov 2017 04:34:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F0E3328F1A for ; Sun, 26 Nov 2017 04:34:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D454428F1E; Sun, 26 Nov 2017 04:34:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 51AE928F1A for ; Sun, 26 Nov 2017 04:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbdKZEeo (ORCPT ); Sat, 25 Nov 2017 23:34:44 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:33494 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751902AbdKZEen (ORCPT ); Sat, 25 Nov 2017 23:34:43 -0500 Received: by mail-pl0-f67.google.com with SMTP id a12so6524058pll.0 for ; Sat, 25 Nov 2017 20:34:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:date:message-id; bh=sXkh0YUMpZ98qahtYRl75yc6+PM30UKs8YCMcT4ZBpY=; b=aqpbnOlwvx886Zr33zljeXyKfiURcP+LvkzDBkjY+CbBGltC1E44PqPkI8Wu3QaiBN DD+expr0XnAF2kQAdmKCq4/eyXRA9ozQm7jpKkVVu9m8zEPmty9twMYxXKysQS/vuDCY wYe7j0zBuNckB7NOsc3Poh4nGdTKQlBtk8RsI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sXkh0YUMpZ98qahtYRl75yc6+PM30UKs8YCMcT4ZBpY=; b=WYai2GuPRzLksTE2RSqpAsAryPc3KZIV1ETiHGD/k0dix30/wGl5Vv2xicc3F7OVeV +CWZRYPMBF6VQYtWglXCwZK9s7u8R24GGH2n3MMOLs759Ek6wYq13TXbma+lOESWYB66 B8Qul/TpBzmbP1ZVpet7n2Ho0IBsc5JuXE2x3+wLlwQMEOKVHiZ0Sh+zNEV83akqVtVQ xdMb9RjSfJ7JNOl6B+6GEqp3X0rWgfDL1uLfy9bVxg1AI3gmv9YHnCeeUgPNTnt0V48/ olRaY4RIcoxVOo2BJJid8Zk5Qi4+1YylW+U1LDRIvxfGQ9Du33ere8mTB8Me6MDo/Gly l4Vg== X-Gm-Message-State: AJaThX4iCoNnQ31zQiMSkq4jCUTOHqC1B3AvAueF2sgMrzvS8Wp61CqU cYelB2nCql2Zx1YSORbP70HDvA== X-Google-Smtp-Source: AGs4zMbmEo2qvuoDJnrmUQw55RHD2wh+Z/iwLt6pVJbAFtJQMEQ1JEe8qoIcaLvkClwjrN7dIkExrQ== X-Received: by 10.159.205.130 with SMTP id v2mr34186544plo.105.1511670883113; Sat, 25 Nov 2017 20:34:43 -0800 (PST) Received: from localhost.localdomain (124-171-106-107.dyn.iinet.net.au. [124.171.106.107]) by smtp.gmail.com with ESMTPSA id i11sm43710243pfk.25.2017.11.25.20.34.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Nov 2017 20:34:42 -0800 (PST) From: Daniel Axtens To: jikos@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, anssi.hannula@iki.fi Cc: Daniel Axtens Subject: [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block Date: Sun, 26 Nov 2017 15:34:04 +1100 Message-Id: <20171126043404.11621-1-dja@axtens.net> X-Mailer: git-send-email 2.11.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If you compile with: CONFIG_HID_HOLTEK=m CONFIG_HOLTEK_FF is not set You get the following warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/hid/hid-holtekff.o see include/linux/module.h for more information Fix this by moving the module info out of the #ifdef CONFIG_HOLTEK_FF block and into the un-guarded part of the file. Signed-off-by: Daniel Axtens Acked-by: Anssi Hannula Reviewed-by: Benjamin Tissoires --- drivers/hid/hid-holtekff.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c index 9325545fc3ae..edc0f64bb584 100644 --- a/drivers/hid/hid-holtekff.c +++ b/drivers/hid/hid-holtekff.c @@ -32,10 +32,6 @@ #ifdef CONFIG_HOLTEK_FF -MODULE_LICENSE("GPL"); -MODULE_AUTHOR("Anssi Hannula "); -MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip based devices"); - /* * These commands and parameters are currently known: * @@ -223,3 +219,7 @@ static struct hid_driver holtek_driver = { .probe = holtek_probe, }; module_hid_driver(holtek_driver); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Anssi Hannula "); +MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip based devices");