From patchwork Sun Feb 25 18:52:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Rivas Costa X-Patchwork-Id: 10241067 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 85E5E60233 for ; Sun, 25 Feb 2018 18:53:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 764B529D35 for ; Sun, 25 Feb 2018 18:53:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A79729D38; Sun, 25 Feb 2018 18:53:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0CE6F29D35 for ; Sun, 25 Feb 2018 18:53:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbeBYSxl (ORCPT ); Sun, 25 Feb 2018 13:53:41 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37320 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbeBYSxK (ORCPT ); Sun, 25 Feb 2018 13:53:10 -0500 Received: by mail-wm0-f67.google.com with SMTP id 139so115655wmn.2; Sun, 25 Feb 2018 10:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9S+zdAlNpKzN964M9ngcHUdFvGoIrMwORUXIkNt11MI=; b=ZZjelGZiaKqRA0fjf9al8TPSIHK/0cEjFFSv9VV4i/C/Hb5lHk7mblEBmYrR620YoG bd18nzy2GE2VQqaIm1bkRmMsfmk7bEazYQxxpJD+hN9p1dTQgn7G2d/iq/W78A/gpuaR jKhq0FD9SRbfwGONNaTFlFgYVFHisr5JiJyciL4WM3aHeGVRT/t1xtCJG6DgsA1vauw8 WE/gFx1Aam+hC+DKn6gQZ5UgtyJ542H8160l8v2Y8gD6hpFX3xnthid9l+EaqrMvfWnG WdXPQ09NmIeTC6ScHQcaLGiiY3ZnqFp+b77pP/KUIqN4ugJD9QgzRYlvRBWdH3ZXbwCC E3pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9S+zdAlNpKzN964M9ngcHUdFvGoIrMwORUXIkNt11MI=; b=CObO7ItP8O8/n0+w/QgkrA8qYIDp42642JoDuW4iKzYsk81b88R46qxZLFhXeVQeZh 8n4eR3yzWbkYffkbCEtifpO9bp0rr0qx7WZ66QSWeZkCNw4nj1h0dz2aPvbmdoK2Whxl 0NiOt0kMmZulOPSXy035KiwvcqM3l6PTFDYS2X15LHwUm1CB6OSw9ZZAD4FGkVrhH3X3 xjsiQVeLSw8VgmYUKb4k2neW3Rv+6T9iSIbpr7jP5v6PPk3OrR4dHJXUZr5SdMOVCQPU ZaMepvPfrg0R5KXharUXYmoozLw8RxoN5CKna12hu7sFoo6OalKBOefiGXtSywaW+zLN perA== X-Gm-Message-State: APf1xPB6WUhswNpApfhWfip3tq0ewftkevCBdHOEDhMm+CLSJhJUG+Tn 9X50GlMZIOncAO3lXwIrLzM= X-Google-Smtp-Source: AG47ELv2mulU+/gnuSbT4XfFM/FGrJNVp5beRfQR3paY1SDWp4loStsrkPiCM+kkII/5P0B0F1ldcQ== X-Received: by 10.28.217.202 with SMTP id q193mr6836011wmg.57.1519584788495; Sun, 25 Feb 2018 10:53:08 -0800 (PST) Received: from localhost.localdomain ([2a01:c50e:5126:7a00:50d8:4f2:c65c:e8e9]) by smtp.gmail.com with ESMTPSA id 72sm6332850wmh.44.2018.02.25.10.53.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Feb 2018 10:53:07 -0800 (PST) From: Rodrigo Rivas Costa To: Jiri Kosina , Benjamin Tissoires , "Pierre-Loup A. Griffais" , Cameron Gutman , =?UTF-8?q?Cl=C3=A9ment=20VUCHENER?= , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: Rodrigo Rivas Costa Subject: [PATCH v3 2/3] HID: steam: add serial number information. Date: Sun, 25 Feb 2018 19:52:49 +0100 Message-Id: <20180225185250.10759-3-rodrigorivascosta@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180225185250.10759-1-rodrigorivascosta@gmail.com> References: <20180225185250.10759-1-rodrigorivascosta@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This device has a feature report to send and receive commands. Use it to get the serial number and set the device's uniq value. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 105 ++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 102 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index 59dbcb95f349..405fae2d2e4b 100644 --- a/drivers/hid/hid-steam.c +++ b/drivers/hid/hid-steam.c @@ -17,6 +17,8 @@ #include #include #include +#include +#include #include "hid-ids.h" MODULE_LICENSE("GPL"); @@ -40,8 +42,99 @@ struct steam_device { unsigned long quirks; struct work_struct work_connect; bool connected; + char serial_no[11]; }; +static int steam_recv_report(struct steam_device *steam, + u8 *data, int size) +{ + struct hid_report *r; + u8 *buf; + int ret; + + r = steam->hdev->report_enum[HID_FEATURE_REPORT].report_id_hash[0]; + if (hid_report_len(r) < 64) + return -EINVAL; + buf = hid_alloc_report_buf(r, GFP_KERNEL); + if (!buf) + return -ENOMEM; + + /* + * The report ID is always 0, so strip the first byte from the output. + * hid_report_len() is not counting the report ID, so +1 to the length + * or else we get a EOVERFLOW. We are safe from a buffer overflow + * because hid_alloc_report_buf() allocates +7 bytes. + */ + ret = hid_hw_raw_request(steam->hdev, 0x00, + buf, hid_report_len(r) + 1, + HID_FEATURE_REPORT, HID_REQ_GET_REPORT); + if (ret > 0) + memcpy(data, buf + 1, min(size, ret - 1)); + kfree(buf); + return ret; +} + +static int steam_send_report(struct steam_device *steam, + u8 *cmd, int size) +{ + struct hid_report *r; + u8 *buf; + int retry; + int ret; + + r = steam->hdev->report_enum[HID_FEATURE_REPORT].report_id_hash[0]; + if (hid_report_len(r) < 64) + return -EINVAL; + buf = hid_alloc_report_buf(r, GFP_KERNEL); + if (!buf) + return -ENOMEM; + + /* The report ID is always 0 */ + memcpy(buf + 1, cmd, size); + + /* + * Sometimes the wireless controller fails with EPIPE + * when sending a feature report. + * Doing a HID_REQ_GET_REPORT and waiting for a while + * seems to fix that. + */ + for (retry = 0; retry < 10; ++retry) { + ret = hid_hw_raw_request(steam->hdev, 0, + buf, size + 1, + HID_FEATURE_REPORT, HID_REQ_SET_REPORT); + if (ret != -EPIPE) + break; + steam_recv_report(steam, NULL, 0); + msleep(50); + } + kfree(buf); + if (ret < 0) + hid_err(steam->hdev, "%s: error %d (%*ph)\n", __func__, + ret, size, cmd); + return ret; +} + +static int steam_get_serial(struct steam_device *steam) +{ + /* + * Send: 0xae 0x15 0x01 + * Recv: 0xae 0x15 0x01 serialnumber (10 chars) + */ + int ret; + u8 cmd[] = {0xae, 0x15, 0x01}; + u8 reply[14]; + + ret = steam_send_report(steam, cmd, sizeof(cmd)); + if (ret < 0) + return ret; + ret = steam_recv_report(steam, reply, sizeof(reply)); + if (ret < 0) + return ret; + reply[13] = 0; + strcpy(steam->serial_no, reply + 3); + return 0; +} + static int steam_input_open(struct input_dev *dev) { struct steam_device *steam = input_get_drvdata(dev); @@ -70,7 +163,12 @@ static int steam_register(struct steam_device *steam) return -ENODEV; } - hid_info(hdev, "Steam Controller connected"); + ret = steam_get_serial(steam); + if (ret) + return ret; + + hid_info(hdev, "Steam Controller '%s' connected", + steam->serial_no); input = input_allocate_device(); if (!input) @@ -85,7 +183,7 @@ static int steam_register(struct steam_device *steam) "Wireless Steam Controller" : "Steam Controller"; input->phys = hdev->phys; - input->uniq = hdev->uniq; + input->uniq = steam->serial_no; input->id.bustype = hdev->bus; input->id.vendor = hdev->vendor; input->id.product = hdev->product; @@ -154,7 +252,8 @@ static void steam_unregister(struct steam_device *steam) if (input) { RCU_INIT_POINTER(steam->input, NULL); synchronize_rcu(); - hid_info(steam->hdev, "Steam Controller disconnected"); + hid_info(steam->hdev, "Steam Controller '%s' disconnected", + steam->serial_no); input_unregister_device(input); } }