From patchwork Sat May 19 00:12:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Kiryanov X-Patchwork-Id: 10412439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B6AC060353 for ; Sat, 19 May 2018 00:12:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93DCF28B06 for ; Sat, 19 May 2018 00:12:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 884C828B0A; Sat, 19 May 2018 00:12:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71DFD28B06 for ; Sat, 19 May 2018 00:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbeESAMW (ORCPT ); Fri, 18 May 2018 20:12:22 -0400 Received: from mail-io0-f201.google.com ([209.85.223.201]:56120 "EHLO mail-io0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbeESAMV (ORCPT ); Fri, 18 May 2018 20:12:21 -0400 Received: by mail-io0-f201.google.com with SMTP id s2-v6so6505593ioa.22 for ; Fri, 18 May 2018 17:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:date:message-id:subject:from:to:cc; bh=7BArSKG9heE8WuRWRa8u7LIQcdXd8N62xq6ik/iP8SU=; b=GNmVUyfnRWzTxdsQiTWlNGkeAMKjbOXZ2RxcOYYZwJmm5jRqr3W9DtzvIt7k08e9CB i7oE5YiEOdJHdyjq1Cmm3LzLkjM8UQfgTZ1zNIUqNNzEMn55M9KdWYoZhCGegYyoPXz4 vqjKwOyfVqBJoei0yZOfp8zslRwU6mzuJu0BiAbmZ/yAPgX30O++SwuBJbkV5MxOJA4Q j0aL/i5Cs/zf26f7DwEqPVrui8g6IOZ62tB59nBKSUwkUAEqib+wxmooek8dODhJ64fw GJa4CvjAMIcZIH06WqM5aQ5pFTFjxTtOuGXaAyy6Sqe7ZAduYPDyXnNfanLbXSqcUEvK F2Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc; bh=7BArSKG9heE8WuRWRa8u7LIQcdXd8N62xq6ik/iP8SU=; b=jKESb4NA/xq+DciXe34Wpvx8+gZoam/LbllPrLpH9GoweLjecOYDf/BnhsE+epzSOw 43HNDRQtGvRSnERyKgoiUn14vUEZrHcCXgkYgJSeN8Nmn/6tVXQKLZcl+w5DXMiewMVa Yb/764kWp0j/Ka8Plei0kd6or8+bRWmk8YtP7+JMSqaRyJ4hGmUTAppBi7cNo1EU1ZKz /bn4yPYBh+yBC5u+DuKDMcAYkm9Kb7djRLutG+Pyhd/oW9JRluv1p8BPGLN5nw5s6bhB r/DjME6yB8l3WPCGGGf8I5eOfezXTBPPjKt6w/2gLrEImw1Om6dVUONy8lBVI7imC3G/ +aqw== X-Gm-Message-State: ALKqPwfIvMYbYWj7jMOSV0syR72HTSHLo+qclSB6/JS0aQh0VpX+rCDk yS8dpHqdjFtsH4rIUg3j0PBUyQCbMj80YSXHDVd3blMRzr+b+3EG+CLMi6zublX5WidvSqroMMX smf6Zp74Pmy5hr15r2DH6okiNUj/NZVW6qVCndPTwg+6hedVBBm8xTtmIbzhx08o= X-Google-Smtp-Source: AB8JxZpqoQm4wcLZ2kCXE5qLxsOhM667tR2zPc5rKpRe1VoEZjRGXfE1qXFx/Oc+WTMS12M1pRG//q/n MIME-Version: 1.0 X-Received: by 2002:a24:6b85:: with SMTP id v127-v6mr4499203itc.18.1526688741173; Fri, 18 May 2018 17:12:21 -0700 (PDT) Date: Fri, 18 May 2018 17:12:13 -0700 Message-Id: <20180519001213.55034-1-rkir@google.com> X-Mailer: git-send-email 2.17.0.441.gb46fe60e1d-goog Subject: [PATCH] Fix checkpatch warnings in goldfish_events.c From: rkir@google.com To: linux-input@vger.kernel.org, rkir@google.com Cc: Roman Kiryanov Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Roman Kiryanov Signed-off-by: Roman Kiryanov --- drivers/input/keyboard/goldfish_events.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/input/keyboard/goldfish_events.c b/drivers/input/keyboard/goldfish_events.c index f6e643b589b6..e8dae6195b30 100644 --- a/drivers/input/keyboard/goldfish_events.c +++ b/drivers/input/keyboard/goldfish_events.c @@ -45,7 +45,7 @@ struct event_dev { static irqreturn_t events_interrupt(int irq, void *dev_id) { struct event_dev *edev = dev_id; - unsigned type, code, value; + unsigned int type, code, value; type = __raw_readl(edev->addr + REG_READ); code = __raw_readl(edev->addr + REG_READ); @@ -57,7 +57,7 @@ static irqreturn_t events_interrupt(int irq, void *dev_id) } static void events_import_bits(struct event_dev *edev, - unsigned long bits[], unsigned type, size_t count) + unsigned long bits[], unsigned int type, size_t count) { void __iomem *addr = edev->addr; int i, j; @@ -99,6 +99,7 @@ static void events_import_abs_params(struct event_dev *edev) for (j = 0; j < ARRAY_SIZE(val); j++) { int offset = (i * ARRAY_SIZE(val) + j) * sizeof(u32); + val[j] = __raw_readl(edev->addr + REG_DATA + offset); } @@ -112,7 +113,7 @@ static int events_probe(struct platform_device *pdev) struct input_dev *input_dev; struct event_dev *edev; struct resource *res; - unsigned keymapnamelen; + unsigned int keymapnamelen; void __iomem *addr; int irq; int i; @@ -150,7 +151,7 @@ static int events_probe(struct platform_device *pdev) for (i = 0; i < keymapnamelen; i++) edev->name[i] = __raw_readb(edev->addr + REG_DATA + i); - pr_debug("events_probe() keymap=%s\n", edev->name); + pr_debug("%s: keymap=%s\n", __func__, edev->name); input_dev->name = edev->name; input_dev->id.bustype = BUS_HOST;