From patchwork Thu May 31 23:37:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Kiryanov X-Patchwork-Id: 10442133 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B66FF602BF for ; Thu, 31 May 2018 23:37:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE20228E6E for ; Thu, 31 May 2018 23:37:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A2C4D28E70; Thu, 31 May 2018 23:37:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E62BD28E6E for ; Thu, 31 May 2018 23:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750850AbeEaXhd (ORCPT ); Thu, 31 May 2018 19:37:33 -0400 Received: from mail-io0-f201.google.com ([209.85.223.201]:42287 "EHLO mail-io0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbeEaXh2 (ORCPT ); Thu, 31 May 2018 19:37:28 -0400 Received: by mail-io0-f201.google.com with SMTP id w24-v6so12218841ioc.9 for ; Thu, 31 May 2018 16:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:date:message-id:subject:from:to:cc; bh=oemvLbHxSTj4wQgLYAUuiPIFt7tzVWrs2CLEbWNAtjU=; b=acKQasQcO3Z1z3tJpxo+X4Kg/Ut51ptI5+bJmgS74uQ7Lpb//5zfpeu7RhUreu5fx2 /t035n+8J2YmPCNGI7O8Co0A0MNymvhDspLZj1LM5sEXNT/x5YI9jw3eGpmznoMJHIoD lnU/CpdonrcEmGtL0tXpylEkFKlu/+XXfg1X4TbTZyuoL4a+XTKAhRj2UDFki1+uyF20 ScRotlM4IGgWouU7Q/mSUxElpdwA9ZtITXpGPZdh5Jnh7dc/ibX0uffjE8KeMgw45H99 HDDN28pQmdkoyz0Xpbt9EukAoCqOp721A7ejXjkOoVByCmYjhIRZOgqCWU7W6J6VwTSn /3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc; bh=oemvLbHxSTj4wQgLYAUuiPIFt7tzVWrs2CLEbWNAtjU=; b=j6q8tX5hG/ks0Dt6U5c1ehwjjZpwxy+bel37+m7EmxhqfgN4Dh+Pbx38A3YcCl4P86 rSTW2eYeTbztOUHV3BcaxnG4yTkYOxyHVHS2GHq3nncDC9LgWTC+8qZUV8HR2eOAN+9b hDxgnCkrys50exxALCVapjz/67DwjabNA7rVnv086Y75UJPx0a6rpjzw+yxnVb55O5lI V09l5h0WKRXNlfS+XxOZ9bCgZwd5vcRrzndAS/Mw0zqiWUWJIJYBIorID8UeM57Y1PSW ChUHTR13uqMj+DTfPAx2OzuBC5K1fqEjv/a7y4pOzsUCJMVSrX5gA7LLdlaATlyIYXVm fPVg== X-Gm-Message-State: ALKqPwcJeESkn40L2VFAHgIIoZyHjJyfdtkWSGXPIfp/Jcy4vaVZ5/nX qde1fzeutsbTQ2p3lxr5INsPbU87 X-Google-Smtp-Source: ADUXVKLb7kMH5kfJhrcTNS8PjFAQFFUBbxDSOwPidbv65SUXiNm01kc0iRBZj3JTxQVDaal6SiYrYAXq MIME-Version: 1.0 X-Received: by 2002:a24:2b03:: with SMTP id h3-v6mr3720009ita.34.1527809847200; Thu, 31 May 2018 16:37:27 -0700 (PDT) Date: Thu, 31 May 2018 16:37:06 -0700 Message-Id: <20180531233707.80702-1-rkir@google.com> X-Mailer: git-send-email 2.17.0.921.gf22659ad46-goog Subject: [PATCH 1/2] Fix checkpatch warnings in goldfish_events.c From: rkir@google.com To: rydberg@bitmath.org Cc: linux-input@vger.kernel.org, Roman Kiryanov Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Roman Kiryanov Address issues pointed by checkpatch.pl Signed-off-by: Roman Kiryanov --- drivers/input/keyboard/goldfish_events.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/input/keyboard/goldfish_events.c b/drivers/input/keyboard/goldfish_events.c index f6e643b589b6..e8dae6195b30 100644 --- a/drivers/input/keyboard/goldfish_events.c +++ b/drivers/input/keyboard/goldfish_events.c @@ -45,7 +45,7 @@ struct event_dev { static irqreturn_t events_interrupt(int irq, void *dev_id) { struct event_dev *edev = dev_id; - unsigned type, code, value; + unsigned int type, code, value; type = __raw_readl(edev->addr + REG_READ); code = __raw_readl(edev->addr + REG_READ); @@ -57,7 +57,7 @@ static irqreturn_t events_interrupt(int irq, void *dev_id) } static void events_import_bits(struct event_dev *edev, - unsigned long bits[], unsigned type, size_t count) + unsigned long bits[], unsigned int type, size_t count) { void __iomem *addr = edev->addr; int i, j; @@ -99,6 +99,7 @@ static void events_import_abs_params(struct event_dev *edev) for (j = 0; j < ARRAY_SIZE(val); j++) { int offset = (i * ARRAY_SIZE(val) + j) * sizeof(u32); + val[j] = __raw_readl(edev->addr + REG_DATA + offset); } @@ -112,7 +113,7 @@ static int events_probe(struct platform_device *pdev) struct input_dev *input_dev; struct event_dev *edev; struct resource *res; - unsigned keymapnamelen; + unsigned int keymapnamelen; void __iomem *addr; int irq; int i; @@ -150,7 +151,7 @@ static int events_probe(struct platform_device *pdev) for (i = 0; i < keymapnamelen; i++) edev->name[i] = __raw_readb(edev->addr + REG_DATA + i); - pr_debug("events_probe() keymap=%s\n", edev->name); + pr_debug("%s: keymap=%s\n", __func__, edev->name); input_dev->name = edev->name; input_dev->id.bustype = BUS_HOST;