| Message ID | 20180618143548.29900-2-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon 18 Jun 07:35 PDT 2018, Vinod Koul wrote: > The Power On driver for Qcom PM 8xxx is a MFD supporting pwrkey and > resin along with the Android reboot-mode. > Add the binding describing this. > > Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > .../devicetree/bindings/power/reset/qcom,pon.txt | 47 ++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt > new file mode 100644 > index 000000000000..d923835425c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt > @@ -0,0 +1,47 @@ > +Qualcomm PON Driver > + > +The Power On driver for Qualcomm PM8xxx is MFD supporting pwrkey and > +resin along with the Android reboot-mode. > + > +This DT node has pwrkey and resin as sub nodes. > + > +Required Properties: > +-compatible: "qcom,pm8916-pon" > +-reg: Specifies the physical address of the pon register > + > +Optional property: Better call these "Optional subnodes". > +-prwrkey: Specifies the subnode pwrkey and should follow the > + qcom,pm8xxx-pwrkey.txt description. > +-resin: Specifies the subnode resin and should follow the > + qcom,pm8xxx-pwrkey.txt description. > + > +The rest of the properties should follow the generic reboot-mode description > +found in reboot-mode.txt > + > +Example: > + > + pon@800 { > + compatible = "qcom,pm8916-pon"; > + > + reg = <0x800>; > + mode-bootloader = <0x2>; > + mode-recovery = <0x1>; > + > + pwrkey { > + compatible = "qcom,pm8941-pwrkey"; > + reg = <0x800>; Didn't we conclude that you could drop the "reg" of the children? Apart from that this looks good. Regards, Bjorn > + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + linux,code = <KEY_POWER>; > + }; > + > + resin { > + compatible = "qcom,pm8941-resin"; > + reg = <0x800>; > + interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + linux,code = <KEY_VOLUMEDOWN>; > + }; > + }; > -- > 2.14.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 22-06-18, 13:58, Bjorn Andersson wrote: > On Mon 18 Jun 07:35 PDT 2018, Vinod Koul wrote: > > > +The Power On driver for Qualcomm PM8xxx is MFD supporting pwrkey and > > +resin along with the Android reboot-mode. > > + > > +This DT node has pwrkey and resin as sub nodes. > > + > > +Required Properties: > > +-compatible: "qcom,pm8916-pon" > > +-reg: Specifies the physical address of the pon register > > + > > +Optional property: > > Better call these "Optional subnodes". Yes will do.. > > +-prwrkey: Specifies the subnode pwrkey and should follow the > > + qcom,pm8xxx-pwrkey.txt description. > > +-resin: Specifies the subnode resin and should follow the > > + qcom,pm8xxx-pwrkey.txt description. > > + > > +The rest of the properties should follow the generic reboot-mode description > > +found in reboot-mode.txt > > + > > +Example: > > + > > + pon@800 { > > + compatible = "qcom,pm8916-pon"; > > + > > + reg = <0x800>; > > + mode-bootloader = <0x2>; > > + mode-recovery = <0x1>; > > + > > + pwrkey { > > + compatible = "qcom,pm8941-pwrkey"; > > + reg = <0x800>; > > Didn't we conclude that you could drop the "reg" of the children? Sloppy me, fixed the code & DTS but not the binding, thanks for pointing > Apart from that this looks good. Thanks :)
diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt new file mode 100644 index 000000000000..d923835425c6 --- /dev/null +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt @@ -0,0 +1,47 @@ +Qualcomm PON Driver + +The Power On driver for Qualcomm PM8xxx is MFD supporting pwrkey and +resin along with the Android reboot-mode. + +This DT node has pwrkey and resin as sub nodes. + +Required Properties: +-compatible: "qcom,pm8916-pon" +-reg: Specifies the physical address of the pon register + +Optional property: +-prwrkey: Specifies the subnode pwrkey and should follow the + qcom,pm8xxx-pwrkey.txt description. +-resin: Specifies the subnode resin and should follow the + qcom,pm8xxx-pwrkey.txt description. + +The rest of the properties should follow the generic reboot-mode description +found in reboot-mode.txt + +Example: + + pon@800 { + compatible = "qcom,pm8916-pon"; + + reg = <0x800>; + mode-bootloader = <0x2>; + mode-recovery = <0x1>; + + pwrkey { + compatible = "qcom,pm8941-pwrkey"; + reg = <0x800>; + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; + debounce = <15625>; + bias-pull-up; + linux,code = <KEY_POWER>; + }; + + resin { + compatible = "qcom,pm8941-resin"; + reg = <0x800>; + interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>; + debounce = <15625>; + bias-pull-up; + linux,code = <KEY_VOLUMEDOWN>; + }; + };
The Power On driver for Qcom PM 8xxx is a MFD supporting pwrkey and resin along with the Android reboot-mode. Add the binding describing this. Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Vinod Koul <vkoul@kernel.org> --- .../devicetree/bindings/power/reset/qcom,pon.txt | 47 ++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt