| Message ID | 20180721191029.25658-1-harshitjain6751@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [01/11] touchscreen: ft5x06: Use octal permissions | expand |
On Sun, 2018-07-22 at 00:39 +0530, dev-harsh1998 wrote: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. > +static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); [] > diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c [] > @@ -461,7 +461,7 @@ name ## _show(struct device *dev, struct device_attribute *attr, char *buf) \ > return v; \ > return sprintf(buf, "%u\n", (unsigned) v); \ > } \ > -static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); > +static DEVICE_ATTR(name, 0444, name ## _show, NULL); I believe this could be static DEVICE_ATTR_RO(name) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c index 5cfe477ec992..4b4a9d84195e 100644 --- a/drivers/input/touchscreen/ad7877.c +++ b/drivers/input/touchscreen/ad7877.c @@ -461,7 +461,7 @@ name ## _show(struct device *dev, struct device_attribute *attr, char *buf) \ return v; \ return sprintf(buf, "%u\n", (unsigned) v); \ } \ -static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); +static DEVICE_ATTR(name, 0444, name ## _show, NULL); SHOW(aux1) SHOW(aux2)
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); Signed-off-by: dev-harsh1998 <harshitjain6751@gmail.com> --- drivers/input/touchscreen/ad7877.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)