From patchwork Sat Jul 21 19:09:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539031 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B84E6A694 for ; Sun, 22 Jul 2018 00:57:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C8E22894E for ; Sat, 21 Jul 2018 19:11:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10BED28950; Sat, 21 Jul 2018 19:11:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B82E028942 for ; Sat, 21 Jul 2018 19:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728398AbeGUUEk (ORCPT ); Sat, 21 Jul 2018 16:04:40 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:46725 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEj (ORCPT ); Sat, 21 Jul 2018 16:04:39 -0400 Received: by mail-wr1-f68.google.com with SMTP id s11-v6so14098166wra.13; Sat, 21 Jul 2018 12:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kN9n0PrhQwGth982mv27AcZIZq4LowLYQ8bufArZCyY=; b=cMoePVApHMX+ORL5ec/As+Aw479/lxyxs24N/6DhqJzVH8dz4N8VL4YEf9JFXmvz/9 JpY6n5VkZyxfubwswCcVFxb5wEo1YxrxE/pNFzW8NZ3fIfgh2Lw9Qh1CNdXrmkFGSZGi bPPFyQcisD5NeS64+RmzCDnytMTHDR2tu/oClWF1QeUdZNV4oqdykhNMyWEXIUTJwIZ9 kDOyWwI7GCdqNfl6Htqh9ccoMp0viFa1MnU+ZEhr/BBJU6jEUzxpVZK3JFr1EIc0dGV0 0TV/xLYY7SDjJ8oTvRYpaPUm0S9+B8Pc5tE+iSlR3OMQjAf+Sc5s48Ss+fmNDbavxOPM rOlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kN9n0PrhQwGth982mv27AcZIZq4LowLYQ8bufArZCyY=; b=qUlAjE415ZlOMBo4UVAF/UHqQnu16UH3nntyQtGwOmMNYSeewKgRWVQThOm/cReF6W MAcDs2nYous6p2jCYWnfOxEXqjOlpLhw7bKWB/kfQ39hoC8h7WvvHf49zUSR1dnwV/Xv CSeet0AagtrDYFm61RuRZ5tNrL4XOLBS20PTFzjn05LxyoWPHAWjOtLHABbN9v2QIv8j 8iuO/+eazgnkm3vRaaF6/cAG9e0DO0hz8V3FY0tQyEYyQ5cV0AN7S5hVOw3FdIqTljdX mnH69+aHWugjvvJX57CIPZSkqVyLMod+P0UtBIHYgndEg91xuV1cx6De2pIAjRJYQIgL pUrQ== X-Gm-Message-State: AOUpUlH/LML2U7M0lFOTJpJjB6omYjwlb0ZDWpZls8KhhFANh43DgtPJ dzytYCOChjWN58SemjyXnLo= X-Google-Smtp-Source: AAOMgpckP4WIJGdrvjBOIxV2cm4oPZgm5hk722bQ8UuHccnOGuCW8lKdx3olWTk+hJBuZtD70Canlw== X-Received: by 2002:adf:96b2:: with SMTP id u47-v6mr4609547wrb.204.1532200252355; Sat, 21 Jul 2018 12:10:52 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.10.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:10:51 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/11] touchscreen: mc13783: Use octal permissions Date: Sun, 22 Jul 2018 00:39:47 +0530 Message-Id: <20180721191029.25658-6-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. +module_param(sample_tolerance, uint, S_IRUGO | S_IWUSR); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/mc13783_ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchscreen/mc13783_ts.c index ef64f36c5ffc..4e33349f101e 100644 --- a/drivers/input/touchscreen/mc13783_ts.c +++ b/drivers/input/touchscreen/mc13783_ts.c @@ -25,9 +25,9 @@ #define DEFAULT_SAMPLE_TOLERANCE 300 static unsigned int sample_tolerance = DEFAULT_SAMPLE_TOLERANCE; -module_param(sample_tolerance, uint, S_IRUGO | S_IWUSR); +module_param(sample_tolerance, uint, 0644); MODULE_PARM_DESC(sample_tolerance, - "If the minimal and maximal value read out for one axis (out " + "If the minimal and maximum value read out for one axis (out " "of three) differ by this value (default: " __stringify(DEFAULT_SAMPLE_TOLERANCE) ") or more, the reading " "is supposed to be wrong and is discarded. Set to 0 to "