From patchwork Sat Jul 21 19:09:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06554A6F3 for ; Sun, 22 Jul 2018 00:57:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FF6528919 for ; Sat, 21 Jul 2018 19:11:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 548C22892E; Sat, 21 Jul 2018 19:11:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F1BD328919 for ; Sat, 21 Jul 2018 19:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728596AbeGUUEt (ORCPT ); Sat, 21 Jul 2018 16:04:49 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:39886 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEs (ORCPT ); Sat, 21 Jul 2018 16:04:48 -0400 Received: by mail-wm0-f68.google.com with SMTP id h20-v6so12643840wmb.4; Sat, 21 Jul 2018 12:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7uafs0jiKUh7lUwZ0AA5KAIpK1U6UC7U/ESXulHGeeE=; b=UCxbVxA9XUsECyLTFuTq2VBRqvpftTYDG6X7u3GTSYQ/nvdJiKsclpIJI8U+n2fwuX 9OUL8DLakUHyjIEySJaL6ex+nXjdwyJUT51NIvNgsg6GY4YwZaIW3suWxQvh6ZDALKOs kk3MzrLHI1IsxYrOv+bfZtakeCdhWs8jOCCpyUwI7obXGPsflNnakBtqqWpqm4tzlDgr bHH9XmDOAJLAvg0mcCu8YWAygemF2yatcO0MyKhBRLevx4GDMlXYdN/LCscr+hw/eZpB t7FLCyYwmghKLG72vik6WUZ3BfemTcjgFeHCmbOiX/NJ0CuPSRMOzJG8rMs2K1g5xl4t qcrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7uafs0jiKUh7lUwZ0AA5KAIpK1U6UC7U/ESXulHGeeE=; b=NSp/R1khHvXCTMCURDl8knDnMXAqRdJjtRFeTOvQHOqGvIzyIgaEf9zhOE2yA6ghmN Xo6fIODpFfqJhScUkdSuMmo2PWhTCKJAcZjUKpAth0PvrsTCvYYztQfUH4XuvTDS8/oo 4KzytvGPJgsApAhiqirGH9FIZvOmZIyYC+bUvdM7dt+Fgq8yARLl0cRFd4RIYkaASmig cfmiSX97aSee1qX91LtepBFwukXwshrCeibDT3xHzsA4c5in8OyKAar6JnKhw5z1R0o9 ii1ILKif1hnpp5DWbWa7bXhC+O7qE2/kk/4hFVvq4k9H7Z0pdgEMFg1+nlb1LZQNoPE3 ME8A== X-Gm-Message-State: AOUpUlFXrZY6fUYEXyq1+YPFZR1d7+W8oZgBf/K9NfvgNd8VpM0MpqGv 5bwVj3Kpk/oMvifAc9fZ1Rc= X-Google-Smtp-Source: AAOMgpeM8oPALGjAEHEHZoTGQZiCqa56MPAT3IOzLG49IXtl9hWY8np3p+YyvhaSTJ5Db2y1OGgPXQ== X-Received: by 2002:a1c:b157:: with SMTP id a84-v6mr3856952wmf.18.1532200261143; Sat, 21 Jul 2018 12:11:01 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.11.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:11:00 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , Jeffrey Lin , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/11] touchscreen: raydium_ts: Use octal permissions Date: Sun, 22 Jul 2018 00:39:49 +0530 Message-Id: <20180721191029.25658-8-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(fw_version, S_IRUGO, raydium_i2c_fw_ver_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(hw_version, S_IRUGO, raydium_i2c_hw_ver_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(boot_mode, S_IRUGO, raydium_i2c_boot_mode_show, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, raydium_i2c_update_fw_store); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(calibrate, S_IWUSR, NULL, raydium_i2c_calibrate_store); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/raydium_i2c_ts.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c index d1c09e6a2cb6..eddbb51e55dd 100644 --- a/drivers/input/touchscreen/raydium_i2c_ts.c +++ b/drivers/input/touchscreen/raydium_i2c_ts.c @@ -934,9 +934,9 @@ static ssize_t raydium_i2c_calibrate_store(struct device *dev, return error ?: count; } -static DEVICE_ATTR(fw_version, S_IRUGO, raydium_i2c_fw_ver_show, NULL); -static DEVICE_ATTR(hw_version, S_IRUGO, raydium_i2c_hw_ver_show, NULL); -static DEVICE_ATTR(boot_mode, S_IRUGO, raydium_i2c_boot_mode_show, NULL); +static DEVICE_ATTR(fw_version, 0444, raydium_i2c_fw_ver_show, NULL); +static DEVICE_ATTR(hw_version, 0444, raydium_i2c_hw_ver_show, NULL); +static DEVICE_ATTR(boot_mode, 0444, raydium_i2c_boot_mode_show, NULL); static DEVICE_ATTR(update_fw, S_IWUSR, NULL, raydium_i2c_update_fw_store); static DEVICE_ATTR(calibrate, S_IWUSR, NULL, raydium_i2c_calibrate_store);