From patchwork Thu Aug 16 06:46:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fengguang Wu X-Patchwork-Id: 10567003 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E52D75A4 for ; Thu, 16 Aug 2018 06:46:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0C0C2ABD4 for ; Thu, 16 Aug 2018 06:46:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C4A752ABF8; Thu, 16 Aug 2018 06:46:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6392B2ABD4 for ; Thu, 16 Aug 2018 06:46:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389020AbeHPJmn (ORCPT ); Thu, 16 Aug 2018 05:42:43 -0400 Received: from mga12.intel.com ([192.55.52.136]:47374 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbeHPJmn (ORCPT ); Thu, 16 Aug 2018 05:42:43 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2018 23:46:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,246,1531810800"; d="scan'208";a="80688158" Received: from bee.sh.intel.com (HELO lkp-server01) ([10.239.97.14]) by fmsmga004.fm.intel.com with ESMTP; 15 Aug 2018 23:46:17 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1fqC2y-0004ex-Vd; Thu, 16 Aug 2018 14:46:16 +0800 Date: Thu, 16 Aug 2018 14:46:02 +0800 From: kbuild test robot To: Roy Im Cc: kbuild-all@01.org, Dmitry Torokhov , Rob Herring , Mark Rutland , Support Opensource , devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Input: fix irqf_oneshot.cocci warnings Message-ID: <20180816064602.GA95363@cairo> References: <662cd241e04a1e033c87d1a94c594740b594b0b6.1534384964.git.Roy.Im@diasemi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <662cd241e04a1e033c87d1a94c594740b594b0b6.1534384964.git.Roy.Im@diasemi.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: kbuild test robot drivers/input/misc/da7280.c:1335:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Fixes: a067f5d53e35 ("Input: new da7280 haptic driver") CC: Roy Im Signed-off-by: kbuild test robot --- Please take the patch only if it's a positive warning. Thanks! da7280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/misc/da7280.c +++ b/drivers/input/misc/da7280.c @@ -1334,7 +1334,7 @@ static int da7280_probe(struct i2c_clien ret = devm_request_threaded_irq(dev, client->irq, NULL, da7280_irq_handler, - DA7280_IRQ_FLAGS, + DA7280_IRQ_FLAGS | IRQF_ONESHOT, "da7280-haptics", haptics); if (ret != 0) { dev_err(dev,