From patchwork Sat Dec 15 16:33:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Mantas_Mikul=C4=97nas?= X-Patchwork-Id: 10732277 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8FE2C14E5 for ; Sat, 15 Dec 2018 16:34:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 724572A5D5 for ; Sat, 15 Dec 2018 16:34:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 60CED2A5EB; Sat, 15 Dec 2018 16:34:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D5B7D2A5D5 for ; Sat, 15 Dec 2018 16:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730213AbeLOQeL (ORCPT ); Sat, 15 Dec 2018 11:34:11 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:44508 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730127AbeLOQeK (ORCPT ); Sat, 15 Dec 2018 11:34:10 -0500 Received: by mail-lj1-f195.google.com with SMTP id k19-v6so7463897lji.11 for ; Sat, 15 Dec 2018 08:34:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fYYw2Pg2lc3BgbBRvZjRGaKaJ70qBqFI4pfB8VX5ZOE=; b=MK1W8TSeLbd+DOe+s2fd6Qj18V+Krpgb3QwFAzQObVKXHAImHDBId0vV4Z214fk9ak QKobOe2ytRNqxC5b0UNvUMbhGnL48KeYhwUoKeaefS2ayo974F0YFJayUq4N44bglKaT 7Sb3X9T4iqD/+lMtX+ZL65f0ho7Xf9baOMbL0mqcq0ZhkqYd5/X1/q1B/qczQ4peD7zr GPZuvKQa0cYV/MzBOjoIRMJLogaHPcHYu121vffs7L9r8hQFzgwajWh/hY77vP9uPJI0 C6TkehQbIhGLFGW+AJMor60bkaaL8Roqz+/y7qzo+C5GHy1V1K0ckorQTlEXhHczS6Yy 6ndA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fYYw2Pg2lc3BgbBRvZjRGaKaJ70qBqFI4pfB8VX5ZOE=; b=cMGppmEehUP6rqTJluGBTbkKJZdnkxlKnllHVvzIwd01Bzu+1qJ/JpUk0ZgcxH5ofl C4aytrUxdsIQt0iDfaORrDYU3ZyCxyAiyqGPVnRG7u/1fD6ot+21++gSbcQinRt4aiLW 6/b5Fih/o1OqQ+rbpoV2LdgGWHYsAdJWgjxasyIJX+cVN3ad06EQvodlsrXj0TJMWShV Gh+rHyYFbkuQAhwIxQ4W1c/IENeESaEHssrnXJNounWlr7HsR9HYviwna8mfCXX2Vfbj 1f3GYvm7kbonMqCkV7yeR3nGo72km5imQV3MrCIkXkErkU7BpGWhB46s/p92Y3doRLnT BikA== X-Gm-Message-State: AA+aEWZ/xAB2+jO6upanbMFRI+yQTCf/x8Fx/VBm+hIG+EVLZOr2zCiz RBvpX4dPG0Q/R2qSgGF6aGy2vFUj4MD2cQ== X-Google-Smtp-Source: AFSGD/UVYowQykhEd2yPSB8ay1VeelRMbLQ8vuym1A16llvCh06Rqd7JzwCGkEd01ICVxxIZ72dVWg== X-Received: by 2002:a2e:82d7:: with SMTP id n23-v6mr3639589ljh.143.1544891648217; Sat, 15 Dec 2018 08:34:08 -0800 (PST) Received: from localhost (78-58-206-110.static.zebra.lt. [78.58.206.110]) by smtp.gmail.com with ESMTPSA id n187sm1588523lfn.59.2018.12.15.08.34.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Dec 2018 08:34:06 -0800 (PST) From: =?utf-8?q?Mantas_Mikul=C4=97nas?= To: linux-input@vger.kernel.org Cc: Dmitry Torokhov , Benjamin Tissoires , =?utf-8?q?Mantas_Mikul?= =?utf-8?q?=C4=97nas?= Subject: [PATCH] Input: synaptics - enable SMBus for HP EliteBook 840 G4 Date: Sat, 15 Dec 2018 18:33:29 +0200 Message-Id: <20181215163329.4710-1-grawity@gmail.com> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP dmesg reports that "Your touchpad (PNP: SYN3052 SYN0100 SYN0002 PNP0f13) says it can support a different bus." I've tested the offered psmouse.synaptics_intertouch=1 with 4.18.x and 4.19.x and it seems to work well. No problems seen with suspend/resume. Also, it appears that RMI/SMBus mode is actually required for 3-4 finger multitouch gestures to work -- otherwise they are not reported at all. Information from dmesg in both modes: psmouse serio3: synaptics: Touchpad model: 1, fw: 8.2, id: 0x1e2b1, caps: 0xf00123/0x840300/0x2e800/0x0, board id: 3139, fw id: 2000742 psmouse serio3: synaptics: Trying to set up SMBus access rmi4_smbus 6-002c: registering SMbus-connected sensor rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3139-001, fw id: 2000742 Signed-off-by: Mantas Mikulėnas Reviewed-by: Benjamin Tissoires --- drivers/input/mouse/synaptics.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 2bd5bb11c8ba..0b5c88609e1f 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -178,6 +178,7 @@ static const char * const smbus_pnp_ids[] = { "LEN0096", /* X280 */ "LEN0097", /* X280 -> ALPS trackpoint */ "LEN200f", /* T450s */ + "SYN3052", /* HP EliteBook 840 G4 */ "SYN3221", /* HP 15-ay000 */ NULL };