From patchwork Fri Jan 11 20:54:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Phillips X-Patchwork-Id: 10760691 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 180A4746 for ; Fri, 11 Jan 2019 21:03:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0714C2A0AF for ; Fri, 11 Jan 2019 21:03:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF1C82A0CB; Fri, 11 Jan 2019 21:03:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 304E22A0AF for ; Fri, 11 Jan 2019 21:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbfAKVDD (ORCPT ); Fri, 11 Jan 2019 16:03:03 -0500 Received: from dnvrco-outbound-snat.email.rr.com ([107.14.73.225]:28716 "EHLO dnvrco-cmomta01.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726568AbfAKVDD (ORCPT ); Fri, 11 Jan 2019 16:03:03 -0500 X-Greylist: delayed 488 seconds by postgrey-1.27 at vger.kernel.org; Fri, 11 Jan 2019 16:03:02 EST Received: from arxi.kimphillips.home ([70.114.206.4]) by cmsmtp with ESMTPA id i3p9g0SGAP088i3pMgLVa2; Fri, 11 Jan 2019 20:54:54 +0000 From: Kim Phillips To: linux-kernel@vger.kernel.org Cc: Kim Phillips , Paul Menzel , Dmitry Torokhov , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH] Input: synaptics - add PNP IDs for Dell XPS models to forcepad Date: Fri, 11 Jan 2019 14:54:30 -0600 Message-Id: <20190111205430.15371-1-kim@kimphillips.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CMAE-Envelope: MS4wfINYwXJKHkH2lXQHr/TYdM0ZZ4qGzNQeOXaBPeCEQnCmMbn9mm819u8q8H9eRSMRkSlzWe8R7mZ5YMMxnU5o1+ppsGyV3LQeFY/RWqRxy7BPHrgqEupD CFT/JRi7yj8fZDn0ZrIxBBp/DaLY1MXhUutNWNv3GVrWZcB+G5QtATYYZN02OpEx0vycOmCB8I0/79mHJ+MWikqqA9iflSq8SdGkcmqsHJ+Ty2nMFYjjiyrt dOwy9x42TcpFX22w7SW/bHEC974hAMoUb+RPTExQr20fpe3Hs86AcOoDfw2ezIkodTSnGdk7zhk/uYgiE4j15qGjp2jXRfn1Tv6sX1XI1vY7LWTW4iLhkyJC 8G/WHbQFdLrAS5zPNLcT7w0kAGV7WnoqwM/+zoeQA/dDjHRkqq8= Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch is the result of seeing this message: psmouse serio1: synaptics: Your touchpad (PNP: DLL087c PNP0f13) says it can support a different bus. If i2c-hid and hid-rmi are not used, you might want to try setting psmouse.synaptics_intertouch to 1 and report this to linux-input@vger.kernel.org. If I set psmouse.synaptics_intertouch=1, or add the PNP ID to smbus_pnp_ids, the touchpad continues to work, and the above message goes away, but we now get: psmouse serio1: synaptics: Trying to set up SMBus access psmouse serio1: synaptics: SMbus companion is not ready yet With this patch applied, i.e., the PNP IDs are added to the forcepad array, the touchpad continues to work and all of the above messages disappear. Tested on a Dell XPS 15 9570. The other IDs - for Dell XPS 13 9350/9360/9370 and XPS 15 9550/9560 - were obtained by searching for the model numbers and "says it can support a different bus". E.g, this is one such instance: https://lkml.org/lkml/2018/2/15/52 Cc: Paul Menzel Cc: Dmitry Torokhov Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Kim Phillips --- With or without this patch, I'm seeing a problem where when the XPS 15 comes out of a resume, and without even touching the touchpad, I notice about 600 interrupts per second firing on the "IR-IO-APIC 51-fasteoi SYNA2393:00" line in /proc/interrupts. If I start using the touchpad, then leave it alone, I check if there are still interrupts firing, and they have indeed stopped. This adversely affects my battery life when using an external mouse. Any ideas on how to debug the situation? Could it be related to the 'vdd not found' messages?: $ dmesg | grep -C 1 -i syna probe of 1-12 returned 1 after 2343 usecs psmouse serio1: synaptics: queried max coordinates: x [..5664], y [..4646] psmouse serio1: synaptics: queried min coordinates: x [1278..], y [1206..] psmouse serio1: synaptics: Touchpad model: 1, fw: 8.2, id: 0x1e2b1, caps: 0xf00123/0x840300/0x12e800/0x0, board id: 3125, fw id: 2378871 input: SynPS/2 Synaptics TouchPad as /devices/platform/i8042/serio1/input/input6 probe of serio1 returned 1 after 939332 usecs -- probe of idma64.1 returned 1 after 72 usecs i2c_hid i2c-SYNA2393:00: i2c-SYNA2393:00 supply vdd not found, using dummy regulator i2c_hid i2c-SYNA2393:00: Linked as a consumer to regulator.0 i2c_hid i2c-SYNA2393:00: i2c-SYNA2393:00 supply vddl not found, using dummy regulator ath10k_pci 0000:3b:00.0: qca6174 hw3.2 target 0x05030000 chip_id 0x00340aff sub 1a56:1535 -- ath10k_pci 0000:3b:00.0: firmware ver WLAN.RM.4.4.1-00079-QCARMSWPZ-1 api 6 features wowlan,ignore-otp crc32 fd869beb probe of i2c-SYNA2393:00 returned 1 after 23978 usecs ath10k_pci 0000:3b:00.0: board_file api 2 bmi_id N/A crc32 20d869c3 -- probe of 0018:056A:488F.0001 returned 1 after 1366 usecs input: SYNA2393:00 06CB:7A13 Mouse as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-10/i2c-SYNA2393:00/0018:06CB:7A13.0002/input/input23 input: SYNA2393:00 06CB:7A13 Touchpad as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-10/i2c-SYNA2393:00/0018:06CB:7A13.0002/input/input24 hid-generic 0018:06CB:7A13.0002: input,hidraw1: I2C HID v1.00 Mouse [SYNA2393:00 06CB:7A13] on i2c-SYNA2393:00 probe of 0018:06CB:7A13.0002 returned 1 after 320 usecs -- probe of 0018:06CB:7A13.0002 returned 0 after 5 usecs input: SYNA2393:00 06CB:7A13 Touchpad as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-10/i2c-SYNA2393:00/0018:06CB:7A13.0002/input/input27 hid-multitouch 0018:06CB:7A13.0002: input,hidraw1: I2C HID v1.00 Mouse [SYNA2393:00 06CB:7A13] on i2c-SYNA2393:00 probe of 0018:06CB:7A13.0002 returned 1 after 25104 usecs drivers/input/mouse/synaptics.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index b6da0c1267e3..e3fb4b9346c0 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -185,6 +185,12 @@ static const char * const smbus_pnp_ids[] = { }; static const char * const forcepad_pnp_ids[] = { + "DLL06e4", /* Dell XPS 15 9550 */ + "DLL0704", /* Dell XPS 13 9350 */ + "DLL075b", /* Dell XPS 13 9360 */ + "DLL07be", /* Dell XPS 15 9560 */ + "DLL07e6", /* Dell XPS 13 9370 */ + "DLL087c", /* Dell XPS 15 9570 */ "SYN300D", "SYN3014", NULL