From patchwork Tue Jan 29 00:37:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 10785107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C693514E1 for ; Tue, 29 Jan 2019 00:37:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B42482B51A for ; Tue, 29 Jan 2019 00:37:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A84AB2B7DC; Tue, 29 Jan 2019 00:37:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D3D62B51A for ; Tue, 29 Jan 2019 00:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbfA2Ahk (ORCPT ); Mon, 28 Jan 2019 19:37:40 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46095 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbfA2Ahk (ORCPT ); Mon, 28 Jan 2019 19:37:40 -0500 Received: by mail-pf1-f193.google.com with SMTP id c73so8786669pfe.13; Mon, 28 Jan 2019 16:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=Q0DGhxaczt609U70/kPzWdo/a0NW1iHZiBbzvJaHoVg=; b=hYN0oAEKnvT4L1gEod8u+6JSMVATyUTQ5I5QZGCnAQIu5/wnDVvQ6QyRw5bJhkuwqk YDOvT5rBeIsCguuA98Ys8LyzT0FAACaf503tWdkqRI3pp6Cp9AFNTmOluoHZ1MvLCqBg c4XZ+pLoKXr3JHEKLHXW5S8AsLr47StUNNJJYrn+izj7xgdqMDNwa7rFSM3TerK09pCg xbbNZK5OXnGZDy5E25i5debfqQ9gOEi9Uh7OjZJiHCkmw4byGvk02mDgs5aOYU2o8MjA Zyf189iRp19Y/T9U+VjTsuvo0ek+AfFJLGEWTg8ZXNVl48L+Oey9NQM/b6bq/nLH5HcP CQTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=Q0DGhxaczt609U70/kPzWdo/a0NW1iHZiBbzvJaHoVg=; b=ISm/v+9+b5KOhCjSLl16ZWHXUGhLAchr3Y+PQoxAMv1ZoZDnAZyKIDNmUitqUms1Qa bmHtH42VIaM9nUHPKaSw/jmQNnJH3kOEWoBI5EyByiGkPLR9QGJw6uenG4o4w1opPaIU eQ9IIlxSgHEa6Ux3xJad/vVrqaEadYi8rE4eykP9unrt4nKKFxbHpTNsPVea0Mout5u+ NG4caK45C+/BR0KKj+3OA+fgOy+tf7XiLFQS6Un94XqjpcCzdTwEdqKNCjiVTDBuQua7 L5xw3r+7agIy35obKPx2m1JYjBTg0mZcaA6rF0AkWmIYrkK6cpB6nHn+nvYC0OT9mVUG Le6Q== X-Gm-Message-State: AJcUukeP8QZ0uFxauBN6GGwjktIv2SpaV0jtFSAER++anS0H6tfWpoDd mFeAPL5OJc8CW4qqyxs7+IaDRfYW X-Google-Smtp-Source: ALg8bN7PRUB14bvrOIiJXvjofbO/Xud3TmQG0Hq6uOgRuFoINNRr0mR4b2DXpXgFr4hkD/egmoLUFQ== X-Received: by 2002:a63:d252:: with SMTP id t18mr21952445pgi.133.1548722259488; Mon, 28 Jan 2019 16:37:39 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id l74sm53812663pfb.145.2019.01.28.16.37.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jan 2019 16:37:38 -0800 (PST) Date: Mon, 28 Jan 2019 16:37:37 -0800 From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Richard Leitner , linux-kernel@vger.kernel.org Subject: [PATCH] Input: sx8654 - do not override interrupt trigger Message-ID: <20190129003737.GA80949@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We should rely on the interrupt trigger (level vs edge) set up by the firmware or board code instead of forcing what we consider appropriate. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/sx8654.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c index 1cc0e4116d3b..b792320d628e 100644 --- a/drivers/input/touchscreen/sx8654.c +++ b/drivers/input/touchscreen/sx8654.c @@ -403,7 +403,7 @@ static int sx8654_probe(struct i2c_client *client, error = devm_request_threaded_irq(&client->dev, client->irq, NULL, sx8654->data->irqh, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + IRQF_ONESHOT, client->name, sx8654); if (error) { dev_err(&client->dev,