From patchwork Sat Feb 9 09:01:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 10804411 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 58AE9922 for ; Sat, 9 Feb 2019 09:01:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4565A2D18D for ; Sat, 9 Feb 2019 09:01:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 355F62D1A3; Sat, 9 Feb 2019 09:01:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D14EA2D18D for ; Sat, 9 Feb 2019 09:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726741AbfBIJBY (ORCPT ); Sat, 9 Feb 2019 04:01:24 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:57136 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbfBIJBY (ORCPT ); Sat, 9 Feb 2019 04:01:24 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x198xo89140302; Sat, 9 Feb 2019 09:01:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2018-07-02; bh=a8AKyqcQ1zyAh9j9ylEGhcmi67eYqao5YeaxyqaB884=; b=OkdKE9HsvszI7exMIsT5AcKE5igczDx8XIVvWA9mvWrSuKil8P7twaoVnAhY5v1IKhh6 hGujvK85eRry6glIcOps6oBmFQf44p/fddFSyvt0ju84HN5XsS4TfUzV2KUKaKPyYQ/5 VJBUVbJqg3INrplwkwANqNe70TZMDwxODUcQ9Q0/RU4XmOOPAtyONwXLYwJHN/soWWac kRBpYqt7tsaFgVJiAXJ1vHn9XNhGHlTnLr5FYWkNjJAs3Q/iJqAFyIO/aIYPJh8MS3mh 1MpW9aS0TBHbYGS7Wm/O4n8ME9JomPmvimr/tG05yPIGTirnkBcuigou6qjIFhSHWai9 HQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2qhredg7yp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 09 Feb 2019 09:01:19 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1991I6s021230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 9 Feb 2019 09:01:19 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1991IKf026371; Sat, 9 Feb 2019 09:01:18 GMT Received: from kadam (/197.157.0.32) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 09 Feb 2019 09:01:17 +0000 Date: Sat, 9 Feb 2019 12:01:06 +0300 From: Dan Carpenter To: Dmitry Torokhov Cc: Rob Herring , Brian Masney , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] Input: msm: Tweak an error message Message-ID: <20190209090106.GB4865@kadam> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9161 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902090067 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The PTR_ERR(NULL) value is zero and it's not useful to print that. Signed-off-by: Dan Carpenter --- drivers/input/misc/msm-vibrator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/misc/msm-vibrator.c b/drivers/input/misc/msm-vibrator.c index c06941021447..69f2579c4ec2 100644 --- a/drivers/input/misc/msm-vibrator.c +++ b/drivers/input/misc/msm-vibrator.c @@ -199,8 +199,7 @@ static int msm_vibrator_probe(struct platform_device *pdev) vibrator->base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!vibrator->base) { - dev_err(&pdev->dev, "Failed to iomap resource: %ld\n", - PTR_ERR(vibrator->base)); + dev_err(&pdev->dev, "Failed to iomap resource.\n"); return -ENOMEM; }