| Message ID | 20190916140358.30036-2-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | DA9063 Onkey Improvements and Fixes | expand |
On 16 September 2019 15:04, Marco Felsch wrote: > The onkey behaviour can be changed by programming the NONKEY_PIN > bitfield. Since the driver supports the reconfiguration we need to add > the documentation here. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > Documentation/devicetree/bindings/input/da9062-onkey.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt > b/Documentation/devicetree/bindings/input/da9062-onkey.txt > index 5f9fbc68e58a..d1792452ceff 100644 > --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt > +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt > @@ -19,6 +19,12 @@ Optional properties: > entry exists the OnKey driver will remove support for the KEY_POWER key > press when triggered using a long press of the OnKey. > > +- dlg,key-opmode : Set the nONKEY behaviour. This value is initial set by the > + otp values. Check [1] for more details. Valid value range: 0x0..0x3 > + > +[1] https://www.dialog-semiconductor.com/sites/default/files/ \ > + da9062_datasheet_3v6.pdf > + As mentioned in my other mail, this can apply to any of the 3 devices, so either we need be explicit and say this is only relevant for DA9061/2 right now, or we should refer to both datasheets. > Example: DA9063 > > pmic0: da9063@58 { > -- > 2.20.1
Hi Adam, On 19-09-16 15:03, Adam Thomson wrote: > On 16 September 2019 15:04, Marco Felsch wrote: > > > The onkey behaviour can be changed by programming the NONKEY_PIN > > bitfield. Since the driver supports the reconfiguration we need to add > > the documentation here. > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > Documentation/devicetree/bindings/input/da9062-onkey.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt > > b/Documentation/devicetree/bindings/input/da9062-onkey.txt > > index 5f9fbc68e58a..d1792452ceff 100644 > > --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt > > +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt > > @@ -19,6 +19,12 @@ Optional properties: > > entry exists the OnKey driver will remove support for the KEY_POWER key > > press when triggered using a long press of the OnKey. > > > > +- dlg,key-opmode : Set the nONKEY behaviour. This value is initial set by the > > + otp values. Check [1] for more details. Valid value range: 0x0..0x3 > > + > > +[1] https://www.dialog-semiconductor.com/sites/default/files/ \ > > + da9062_datasheet_3v6.pdf > > + > > As mentioned in my other mail, this can apply to any of the 3 devices, so either > we need be explicit and say this is only relevant for DA9061/2 right now, or we > should refer to both datasheets. We can go with both datasheets, please check my reply on your mail. Regards, Marco > > > Example: DA9063 > > > > pmic0: da9063@58 { > > -- > > 2.20.1 > >
diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt b/Documentation/devicetree/bindings/input/da9062-onkey.txt index 5f9fbc68e58a..d1792452ceff 100644 --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt @@ -19,6 +19,12 @@ Optional properties: entry exists the OnKey driver will remove support for the KEY_POWER key press when triggered using a long press of the OnKey. +- dlg,key-opmode : Set the nONKEY behaviour. This value is initial set by the + otp values. Check [1] for more details. Valid value range: 0x0..0x3 + +[1] https://www.dialog-semiconductor.com/sites/default/files/ \ + da9062_datasheet_3v6.pdf + Example: DA9063 pmic0: da9063@58 {
The onkey behaviour can be changed by programming the NONKEY_PIN bitfield. Since the driver supports the reconfiguration we need to add the documentation here. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- Documentation/devicetree/bindings/input/da9062-onkey.txt | 6 ++++++ 1 file changed, 6 insertions(+)