From patchwork Tue Sep 17 09:42:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wang, Jiada" X-Patchwork-Id: 11148455 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 593B414DB for ; Tue, 17 Sep 2019 09:42:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4185820862 for ; Tue, 17 Sep 2019 09:42:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729157AbfIQJmn (ORCPT ); Tue, 17 Sep 2019 05:42:43 -0400 Received: from esa4.mentor.iphmx.com ([68.232.137.252]:22250 "EHLO esa4.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729031AbfIQJmn (ORCPT ); Tue, 17 Sep 2019 05:42:43 -0400 IronPort-SDR: Id2txxyCopHDcIPsZIgMZ2m684nTqH07pICo5sZkrCEPazxB9tIBCg90EdDW81fZAqkfS6nnXE Hb9SWzX3E7Of08PDN33z6SAGJOKTkPaqkhInM8tu7GI0pAKVNLiTt6Cu0qVtwL4RjLERfNsHBS EPI8ASFqrTS4733HoynXxYY/jT+kQVju3shoVMFC7DwfN53MHHUdqsIK8yyA98u6PHG094WC80 8XO9AYEsAASrTH3Zu/tbYTsCz1vIBg403tYKZn5yPTVw3qbF1Z3bKKUFkVBBmAkI5DqrArmhAT QD4= X-IronPort-AV: E=Sophos;i="5.64,515,1559548800"; d="scan'208";a="41423274" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 17 Sep 2019 01:42:42 -0800 IronPort-SDR: zzd8K7Fy7QSIx2Z46kbdqOJcQWBD9XpjfiZjtKNEiZsal5atj9+QN5+iceochZhnbLIItvdoBK iFWXDeyGy+zZG0KUlzgw+KxGqZK1tkuDkOQTZwCe9Wti6Intf3aHK6dGNxZr1FPeZYJ16JeulY pSznt2I7blYX1f86FwkA8EnfhtgXJgwnficLUWS27ETD9uGTV15SyZsepyjn99pwCEt+IawtTJ kHZtAzHcM9LFEgTs0cImaW0RZnJcneSZbNfSZa5JXjzZ/+E/aNLeOzr632jHO/xPzyCJAtY5QI hKw= From: Jiada Wang To: , , , , CC: , , Subject: [PATCH v3 40/49] Input: Atmel: improve error handling in mxt_initialize() Date: Tue, 17 Sep 2019 18:42:16 +0900 Message-ID: <20190917094225.18927-2-jiada_wang@mentor.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190917094225.18927-1-jiada_wang@mentor.com> References: <20190917094225.18927-1-jiada_wang@mentor.com> MIME-Version: 1.0 X-ClientProxiedBy: svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Deepak Das Currently mxt_initialize() tries to probe bootloader mode even if valid bootloader address is not specified. This commit modifies mxt_initialize() to return error if Device is not in appmode and bootloader address is not specified. This commit also returns error code from mxt_send_bootloader_cmd() in mxt_initialize(). Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 58 +++++++++++++++++------- 1 file changed, 41 insertions(+), 17 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 2fac43da0a2b..b260ac155b5e 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -716,17 +716,13 @@ static int mxt_lookup_bootloader_address(struct mxt_data *data, bool retry) return 0; } -static int mxt_probe_bootloader(struct mxt_data *data, bool alt_address) +static int mxt_probe_bootloader(struct mxt_data *data) { struct device *dev = &data->client->dev; int error; u8 buf[3]; bool crc_failure, extended_id; - error = mxt_lookup_bootloader_address(data, alt_address); - if (error) - return error; - /* Check bootloader status and version information */ error = mxt_bootloader_read(data, buf, sizeof(buf)); if (error) @@ -2923,6 +2919,32 @@ static void mxt_config_cb(const struct firmware *cfg, void *ctx) release_firmware(cfg); } +static int mxt_bootloader_status(struct mxt_data *data) +{ + struct i2c_client *client = data->client; + int error; + + error = mxt_lookup_bootloader_address(data, false); + if (error) { + dev_info(&client->dev, + "Bootloader address is not specified\n"); + return error; + } + /* Check bootloader state */ + error = mxt_probe_bootloader(data); + if (error) { + dev_info(&client->dev, "Trying alternate bootloader address\n"); + mxt_lookup_bootloader_address(data, true); + error = mxt_probe_bootloader(data); + if (error) { + dev_err(&client->dev, + "Chip is not in appmode or bootloader mode\n"); + return error; + } + } + return 0; +} + static int mxt_initialize(struct mxt_data *data) { struct i2c_client *client = data->client; @@ -2934,16 +2956,13 @@ static int mxt_initialize(struct mxt_data *data) if (!error) break; - /* Check bootloader state */ - error = mxt_probe_bootloader(data, false); - if (error) { - dev_info(&client->dev, "Trying alternate bootloader address\n"); - error = mxt_probe_bootloader(data, true); - if (error) { - /* Chip is not in appmode or bootloader mode */ - return error; - } - } + dev_info(&client->dev, + "info block read failed (%d), so try bootloader method\n", + error); + + error = mxt_bootloader_status(data); + if (error) + return error; /* OK, we are in bootloader, see if we can recover */ if (++recovery_attempts > 1) { @@ -2957,7 +2976,9 @@ static int mxt_initialize(struct mxt_data *data) } /* Attempt to exit bootloader into app mode */ - mxt_send_bootloader_cmd(data, false); + error = mxt_send_bootloader_cmd(data, false); + if (error) + return error; msleep(MXT_FW_RESET_TIME); } @@ -3649,8 +3670,11 @@ static int mxt_enter_bootloader(struct mxt_data *data) msleep(MXT_RESET_TIME); + ret = mxt_lookup_bootloader_address(data, false); + if (ret) + return ret; /* Do not need to scan since we know family ID */ - ret = mxt_probe_bootloader(data, 0); + ret = mxt_probe_bootloader(data); if (ret) return ret;