| Message ID | 20191119105118.54285-4-hverkuil-cisco@xs4all.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | input: rmi4/synaptics fixes | expand |
Hi Dmitry, Is it OK with you I merge this patch via the media subsystem? It's pretty independent of the other rmi4 patches in this series, so it makes sense that I handle this one. Regards, Hans On 11/19/19 11:51 AM, Hans Verkuil wrote: > Testing with the rmi_f54 driver on the Lenovo X1 Carbon 6th gen > laptop showed that the data is in little endian format. Update > the documentation accordingly. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> > --- > .../media/uapi/v4l/pixfmt-tch-td16.rst | 34 +++++++++---------- > .../media/uapi/v4l/pixfmt-tch-tu16.rst | 34 +++++++++---------- > 2 files changed, 34 insertions(+), 34 deletions(-) > > diff --git a/Documentation/media/uapi/v4l/pixfmt-tch-td16.rst b/Documentation/media/uapi/v4l/pixfmt-tch-td16.rst > index 4031b175257c..6f1be873bec1 100644 > --- a/Documentation/media/uapi/v4l/pixfmt-tch-td16.rst > +++ b/Documentation/media/uapi/v4l/pixfmt-tch-td16.rst > @@ -15,7 +15,7 @@ V4L2_TCH_FMT_DELTA_TD16 ('TD16') > > *man V4L2_TCH_FMT_DELTA_TD16(2)* > > -16-bit signed Touch Delta > +16-bit signed little endian Touch Delta > > > Description > @@ -37,38 +37,38 @@ Each cell is one byte. > :widths: 2 1 1 1 1 1 1 1 1 > > * - start + 0: > - - D'\ :sub:`00high` > - D'\ :sub:`00low` > - - D'\ :sub:`01high` > + - D'\ :sub:`00high` > - D'\ :sub:`01low` > - - D'\ :sub:`02high` > + - D'\ :sub:`01high` > - D'\ :sub:`02low` > - - D'\ :sub:`03high` > + - D'\ :sub:`02high` > - D'\ :sub:`03low` > + - D'\ :sub:`03high` > * - start + 8: > - - D'\ :sub:`10high` > - D'\ :sub:`10low` > - - D'\ :sub:`11high` > + - D'\ :sub:`10high` > - D'\ :sub:`11low` > - - D'\ :sub:`12high` > + - D'\ :sub:`11high` > - D'\ :sub:`12low` > - - D'\ :sub:`13high` > + - D'\ :sub:`12high` > - D'\ :sub:`13low` > + - D'\ :sub:`13high` > * - start + 16: > - - D'\ :sub:`20high` > - D'\ :sub:`20low` > - - D'\ :sub:`21high` > + - D'\ :sub:`20high` > - D'\ :sub:`21low` > - - D'\ :sub:`22high` > + - D'\ :sub:`21high` > - D'\ :sub:`22low` > - - D'\ :sub:`23high` > + - D'\ :sub:`22high` > - D'\ :sub:`23low` > + - D'\ :sub:`23high` > * - start + 24: > - - D'\ :sub:`30high` > - D'\ :sub:`30low` > - - D'\ :sub:`31high` > + - D'\ :sub:`30high` > - D'\ :sub:`31low` > - - D'\ :sub:`32high` > + - D'\ :sub:`31high` > - D'\ :sub:`32low` > - - D'\ :sub:`33high` > + - D'\ :sub:`32high` > - D'\ :sub:`33low` > + - D'\ :sub:`33high` > diff --git a/Documentation/media/uapi/v4l/pixfmt-tch-tu16.rst b/Documentation/media/uapi/v4l/pixfmt-tch-tu16.rst > index 8278543be99a..cb3da6687a58 100644 > --- a/Documentation/media/uapi/v4l/pixfmt-tch-tu16.rst > +++ b/Documentation/media/uapi/v4l/pixfmt-tch-tu16.rst > @@ -15,7 +15,7 @@ V4L2_TCH_FMT_TU16 ('TU16') > > *man V4L2_TCH_FMT_TU16(2)* > > -16-bit unsigned raw touch data > +16-bit unsigned little endian raw touch data > > > Description > @@ -36,38 +36,38 @@ Each cell is one byte. > :widths: 2 1 1 1 1 1 1 1 1 > > * - start + 0: > - - R'\ :sub:`00high` > - R'\ :sub:`00low` > - - R'\ :sub:`01high` > + - R'\ :sub:`00high` > - R'\ :sub:`01low` > - - R'\ :sub:`02high` > + - R'\ :sub:`01high` > - R'\ :sub:`02low` > - - R'\ :sub:`03high` > + - R'\ :sub:`02high` > - R'\ :sub:`03low` > + - R'\ :sub:`03high` > * - start + 8: > - - R'\ :sub:`10high` > - R'\ :sub:`10low` > - - R'\ :sub:`11high` > + - R'\ :sub:`10high` > - R'\ :sub:`11low` > - - R'\ :sub:`12high` > + - R'\ :sub:`11high` > - R'\ :sub:`12low` > - - R'\ :sub:`13high` > + - R'\ :sub:`12high` > - R'\ :sub:`13low` > + - R'\ :sub:`13high` > * - start + 16: > - - R'\ :sub:`20high` > - R'\ :sub:`20low` > - - R'\ :sub:`21high` > + - R'\ :sub:`20high` > - R'\ :sub:`21low` > - - R'\ :sub:`22high` > + - R'\ :sub:`21high` > - R'\ :sub:`22low` > - - R'\ :sub:`23high` > + - R'\ :sub:`22high` > - R'\ :sub:`23low` > + - R'\ :sub:`23high` > * - start + 24: > - - R'\ :sub:`30high` > - R'\ :sub:`30low` > - - R'\ :sub:`31high` > + - R'\ :sub:`30high` > - R'\ :sub:`31low` > - - R'\ :sub:`32high` > + - R'\ :sub:`31high` > - R'\ :sub:`32low` > - - R'\ :sub:`33high` > + - R'\ :sub:`32high` > - R'\ :sub:`33low` > + - R'\ :sub:`33high` >
Hi Hans, On Sat, Nov 23, 2019 at 05:12:43PM +0100, Hans Verkuil wrote: > Hi Dmitry, > > Is it OK with you I merge this patch via the media subsystem? Yes, absolutely. It does not touch any of the input bits so I actually expected it to go through media tree. Thanks!
diff --git a/Documentation/media/uapi/v4l/pixfmt-tch-td16.rst b/Documentation/media/uapi/v4l/pixfmt-tch-td16.rst index 4031b175257c..6f1be873bec1 100644 --- a/Documentation/media/uapi/v4l/pixfmt-tch-td16.rst +++ b/Documentation/media/uapi/v4l/pixfmt-tch-td16.rst @@ -15,7 +15,7 @@ V4L2_TCH_FMT_DELTA_TD16 ('TD16') *man V4L2_TCH_FMT_DELTA_TD16(2)* -16-bit signed Touch Delta +16-bit signed little endian Touch Delta Description @@ -37,38 +37,38 @@ Each cell is one byte. :widths: 2 1 1 1 1 1 1 1 1 * - start + 0: - - D'\ :sub:`00high` - D'\ :sub:`00low` - - D'\ :sub:`01high` + - D'\ :sub:`00high` - D'\ :sub:`01low` - - D'\ :sub:`02high` + - D'\ :sub:`01high` - D'\ :sub:`02low` - - D'\ :sub:`03high` + - D'\ :sub:`02high` - D'\ :sub:`03low` + - D'\ :sub:`03high` * - start + 8: - - D'\ :sub:`10high` - D'\ :sub:`10low` - - D'\ :sub:`11high` + - D'\ :sub:`10high` - D'\ :sub:`11low` - - D'\ :sub:`12high` + - D'\ :sub:`11high` - D'\ :sub:`12low` - - D'\ :sub:`13high` + - D'\ :sub:`12high` - D'\ :sub:`13low` + - D'\ :sub:`13high` * - start + 16: - - D'\ :sub:`20high` - D'\ :sub:`20low` - - D'\ :sub:`21high` + - D'\ :sub:`20high` - D'\ :sub:`21low` - - D'\ :sub:`22high` + - D'\ :sub:`21high` - D'\ :sub:`22low` - - D'\ :sub:`23high` + - D'\ :sub:`22high` - D'\ :sub:`23low` + - D'\ :sub:`23high` * - start + 24: - - D'\ :sub:`30high` - D'\ :sub:`30low` - - D'\ :sub:`31high` + - D'\ :sub:`30high` - D'\ :sub:`31low` - - D'\ :sub:`32high` + - D'\ :sub:`31high` - D'\ :sub:`32low` - - D'\ :sub:`33high` + - D'\ :sub:`32high` - D'\ :sub:`33low` + - D'\ :sub:`33high` diff --git a/Documentation/media/uapi/v4l/pixfmt-tch-tu16.rst b/Documentation/media/uapi/v4l/pixfmt-tch-tu16.rst index 8278543be99a..cb3da6687a58 100644 --- a/Documentation/media/uapi/v4l/pixfmt-tch-tu16.rst +++ b/Documentation/media/uapi/v4l/pixfmt-tch-tu16.rst @@ -15,7 +15,7 @@ V4L2_TCH_FMT_TU16 ('TU16') *man V4L2_TCH_FMT_TU16(2)* -16-bit unsigned raw touch data +16-bit unsigned little endian raw touch data Description @@ -36,38 +36,38 @@ Each cell is one byte. :widths: 2 1 1 1 1 1 1 1 1 * - start + 0: - - R'\ :sub:`00high` - R'\ :sub:`00low` - - R'\ :sub:`01high` + - R'\ :sub:`00high` - R'\ :sub:`01low` - - R'\ :sub:`02high` + - R'\ :sub:`01high` - R'\ :sub:`02low` - - R'\ :sub:`03high` + - R'\ :sub:`02high` - R'\ :sub:`03low` + - R'\ :sub:`03high` * - start + 8: - - R'\ :sub:`10high` - R'\ :sub:`10low` - - R'\ :sub:`11high` + - R'\ :sub:`10high` - R'\ :sub:`11low` - - R'\ :sub:`12high` + - R'\ :sub:`11high` - R'\ :sub:`12low` - - R'\ :sub:`13high` + - R'\ :sub:`12high` - R'\ :sub:`13low` + - R'\ :sub:`13high` * - start + 16: - - R'\ :sub:`20high` - R'\ :sub:`20low` - - R'\ :sub:`21high` + - R'\ :sub:`20high` - R'\ :sub:`21low` - - R'\ :sub:`22high` + - R'\ :sub:`21high` - R'\ :sub:`22low` - - R'\ :sub:`23high` + - R'\ :sub:`22high` - R'\ :sub:`23low` + - R'\ :sub:`23high` * - start + 24: - - R'\ :sub:`30high` - R'\ :sub:`30low` - - R'\ :sub:`31high` + - R'\ :sub:`30high` - R'\ :sub:`31low` - - R'\ :sub:`32high` + - R'\ :sub:`31high` - R'\ :sub:`32low` - - R'\ :sub:`33high` + - R'\ :sub:`32high` - R'\ :sub:`33low` + - R'\ :sub:`33high`
Testing with the rmi_f54 driver on the Lenovo X1 Carbon 6th gen laptop showed that the data is in little endian format. Update the documentation accordingly. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> --- .../media/uapi/v4l/pixfmt-tch-td16.rst | 34 +++++++++---------- .../media/uapi/v4l/pixfmt-tch-tu16.rst | 34 +++++++++---------- 2 files changed, 34 insertions(+), 34 deletions(-)