| Message ID | 20191217152541.2167080-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | cbe821a20f3d46b419caa6fccf9e9812fff0e392 |
| Headers | show |
| Series | Input: axp20x-pek - make device attributes static | expand |
On Tue, Dec 17, 2019 at 11:25 PM Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> wrote: > > The two device attrbitues are not declared outside this file > so make them static to avoid the following warnings: > > drivers/input/misc/axp20x-pek.c:194:1: warning: symbol 'dev_attr_startup' was not declared. Should it be static? > drivers/input/misc/axp20x-pek.c:195:1: warning: symbol 'dev_attr_shutdown' was not declared. Should it be static? > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> > --- > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: linux-input@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Acked-by: Chen-Yu Tsai <wens@csie.org>
diff --git a/drivers/input/misc/axp20x-pek.c b/drivers/input/misc/axp20x-pek.c index 17c1cca74498..4454f1e5a0d3 100644 --- a/drivers/input/misc/axp20x-pek.c +++ b/drivers/input/misc/axp20x-pek.c @@ -191,9 +191,10 @@ static ssize_t axp20x_store_attr_shutdown(struct device *dev, axp20x_pek->info->shutdown_mask, buf, count); } -DEVICE_ATTR(startup, 0644, axp20x_show_attr_startup, axp20x_store_attr_startup); -DEVICE_ATTR(shutdown, 0644, axp20x_show_attr_shutdown, - axp20x_store_attr_shutdown); +static DEVICE_ATTR(startup, 0644, axp20x_show_attr_startup, + axp20x_store_attr_startup); +static DEVICE_ATTR(shutdown, 0644, axp20x_show_attr_shutdown, + axp20x_store_attr_shutdown); static struct attribute *axp20x_attrs[] = { &dev_attr_startup.attr,
The two device attrbitues are not declared outside this file so make them static to avoid the following warnings: drivers/input/misc/axp20x-pek.c:194:1: warning: symbol 'dev_attr_startup' was not declared. Should it be static? drivers/input/misc/axp20x-pek.c:195:1: warning: symbol 'dev_attr_shutdown' was not declared. Should it be static? Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> --- Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Chen-Yu Tsai <wens@csie.org> Cc: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/input/misc/axp20x-pek.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)