| Message ID | 20200131124625.27895-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | f454d9a378a1ccb676adfa6e2449ef17e66696b5 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: quirks: Remove ITE 8595 entry from hid_have_special_driver | expand |
On Fri, 31 Jan 2020, Hans de Goede wrote: > The ITE 8595 chip used in various 2-in-1 keyboard docks works fine with > the hid-generic driver (minus the RF_KILL key) and also keeps working fine > when swapping drivers, so there is no need to have it in the > hid_have_special_driver list. > > Note the other 2 USB ids in hid-ite.c were never added to > hid_have_special_driver. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/hid/hid-quirks.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c > index 0e7b2d998395..503cfbe207ab 100644 > --- a/drivers/hid/hid-quirks.c > +++ b/drivers/hid/hid-quirks.c > @@ -397,9 +397,6 @@ static const struct hid_device_id hid_have_special_driver[] = { > { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081) }, > { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A0C2) }, > #endif > -#if IS_ENABLED(CONFIG_HID_ITE) > - { HID_USB_DEVICE(USB_VENDOR_ID_ITE, USB_DEVICE_ID_ITE8595) }, > -#endif > #if IS_ENABLED(CONFIG_HID_ICADE) > { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ION, USB_DEVICE_ID_ICADE) }, > #endif Applied, thank you Hans.
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c index 0e7b2d998395..503cfbe207ab 100644 --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c @@ -397,9 +397,6 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081) }, { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A0C2) }, #endif -#if IS_ENABLED(CONFIG_HID_ITE) - { HID_USB_DEVICE(USB_VENDOR_ID_ITE, USB_DEVICE_ID_ITE8595) }, -#endif #if IS_ENABLED(CONFIG_HID_ICADE) { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ION, USB_DEVICE_ID_ICADE) }, #endif
The ITE 8595 chip used in various 2-in-1 keyboard docks works fine with the hid-generic driver (minus the RF_KILL key) and also keeps working fine when swapping drivers, so there is no need to have it in the hid_have_special_driver list. Note the other 2 USB ids in hid-ite.c were never added to hid_have_special_driver. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/hid/hid-quirks.c | 3 --- 1 file changed, 3 deletions(-)