| Message ID | 20200214130249.6845-3-merlijn@wizzup.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add SW_MACHINE_COVER key | expand |
Hi, On Fri, Feb 14, 2020 at 02:02:48PM +0100, Merlijn Wajer wrote: > Instead, expose the key via the input framework, as SW_MACHINE_COVER How about: The chip-detect GPIO is actually detecting if the cover is closed. Technically it's possible to use the SD card with open cover. The only downside is risk of battery falling out and user being able to physically remove the card. The behaviour of SD card not being available when the device is open is unexpected and creates more problems than it solves. There is a high chance, that more people accidently break their rootfs by opening the case without physically removing the card. > --- Missing SoB. Patch itself is Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > arch/arm/boot/dts/omap3-n900.dts | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > index 7028a7cb2849..ed773e1609a5 100644 > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -108,6 +108,14 @@ > linux,code = <SW_FRONT_PROXIMITY>; > linux,can-disable; > }; > + > + machine_cover { > + label = "Machine Cover"; > + gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */ > + linux,input-type = <EV_SW>; > + linux,code = <SW_MACHINE_COVER>; > + linux,can-disable; > + }; > }; > > isp1707: isp1707 { > @@ -805,10 +813,6 @@ > pinctrl-0 = <&mmc1_pins>; > vmmc-supply = <&vmmc1>; > bus-width = <4>; > - /* For debugging, it is often good idea to remove this GPIO. > - It means you can remove back cover (to reboot by removing > - battery) and still use the MMC card. */ > - cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */ > }; > > /* most boards use vaux3, only some old versions use vmmc2 instead */ > -- > 2.23.0 >
Hi, On 14/02/2020 15:49, Sebastian Reichel wrote: > Hi, > > On Fri, Feb 14, 2020 at 02:02:48PM +0100, Merlijn Wajer wrote: >> Instead, expose the key via the input framework, as SW_MACHINE_COVER > > How about: > > The chip-detect GPIO is actually detecting if the cover is closed. > Technically it's possible to use the SD card with open cover. The > only downside is risk of battery falling out and user being able > to physically remove the card. > > The behaviour of SD card not being available when the device is > open is unexpected and creates more problems than it solves. There > is a high chance, that more people accidently break their rootfs > by opening the case without physically removing the card. Sounds good. > Missing SoB. Will add. > Patch itself is > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Thanks. Cheers, Merlijn
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 7028a7cb2849..ed773e1609a5 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -108,6 +108,14 @@ linux,code = <SW_FRONT_PROXIMITY>; linux,can-disable; }; + + machine_cover { + label = "Machine Cover"; + gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */ + linux,input-type = <EV_SW>; + linux,code = <SW_MACHINE_COVER>; + linux,can-disable; + }; }; isp1707: isp1707 { @@ -805,10 +813,6 @@ pinctrl-0 = <&mmc1_pins>; vmmc-supply = <&vmmc1>; bus-width = <4>; - /* For debugging, it is often good idea to remove this GPIO. - It means you can remove back cover (to reboot by removing - battery) and still use the MMC card. */ - cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */ }; /* most boards use vaux3, only some old versions use vmmc2 instead */