From patchwork Wed Mar 18 19:27:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Filipe_La=C3=ADns?= X-Patchwork-Id: 11445861 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 594171667 for ; Wed, 18 Mar 2020 19:27:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 421922072C for ; Wed, 18 Mar 2020 19:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726663AbgCRT1y (ORCPT ); Wed, 18 Mar 2020 15:27:54 -0400 Received: from orion.archlinux.org ([88.198.91.70]:44064 "EHLO orion.archlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbgCRT1y (ORCPT ); Wed, 18 Mar 2020 15:27:54 -0400 Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 4BE1D1A33C6879; Wed, 18 Mar 2020 19:27:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on orion.archlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=ALL_TRUSTED=-1,BAYES_00=-1, DMARC_FAIL_NONE=0.25,T_DMARC_POLICY_NONE=0.01,T_DMARC_TESTS_FAIL=0.01 autolearn=no autolearn_force=no version=3.4.4 X-Spam-BL-Results: Received: from localhost.localdomain (unknown [IPv6:2001:8a0:f254:2300:dad6:8c60:8394:88da]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ffy00) by orion.archlinux.org (Postfix) with ESMTPSA; Wed, 18 Mar 2020 19:27:51 +0000 (UTC) From: =?utf-8?q?Filipe_La=C3=ADns?= To: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Hutterer , Hans de Goede , Mario Limonciello , Richard Hughes Cc: =?utf-8?q?Filipe_La=C3=ADns?= Subject: [PATCH v2] HID: logitech-dj: issue udev change event on device connection Date: Wed, 18 Mar 2020 19:27:21 +0000 Message-Id: <20200318192721.390630-1-lains@archlinux.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200318161906.3340959-1-lains@archlinux.org> References: <20200318161906.3340959-1-lains@archlinux.org> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org As discussed in the mailing list: > Right now the hid-logitech-dj driver will export one node for each > connected device, even when the device is not connected. That causes > some trouble because in userspace we don't have have any way to know if > the device is connected or not, so when we try to communicate, if the > device is disconnected it will fail. The solution reached to solve this issue is to trigger an udev change event when the device connects, this way userspace can just wait on those connections instead of trying to ping the device. Signed-off-by: Filipe Laíns --- v2: - Issue udev change event on the connected hid device, not on the receiver --- drivers/hid/hid-logitech-dj.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 48dff5d6b605..282e57dd467d 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -1412,6 +1412,7 @@ static int logi_dj_dj_event(struct hid_device *hdev, { struct dj_receiver_dev *djrcv_dev = hid_get_drvdata(hdev); struct dj_report *dj_report = (struct dj_report *) data; + struct dj_device *dj_dev; unsigned long flags; /* @@ -1447,7 +1448,9 @@ static int logi_dj_dj_event(struct hid_device *hdev, spin_lock_irqsave(&djrcv_dev->lock, flags); - if (!djrcv_dev->paired_dj_devices[dj_report->device_index]) { + dj_dev = djrcv_dev->paired_dj_devices[dj_report->device_index]; + + if (!dj_dev) { /* received an event for an unknown device, bail out */ logi_dj_recv_queue_notification(djrcv_dev, dj_report); goto out; @@ -1464,6 +1467,8 @@ static int logi_dj_dj_event(struct hid_device *hdev, if (dj_report->report_params[CONNECTION_STATUS_PARAM_STATUS] == STATUS_LINKLOSS) { logi_dj_recv_forward_null_report(djrcv_dev, dj_report); + } else { + kobject_uevent(&dj_dev->hdev->dev.kobj, KOBJ_CHANGE); } break; default: