From patchwork Fri Apr 17 11:40:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 11494845 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C3978174A for ; Fri, 17 Apr 2020 11:40:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD563221EA for ; Fri, 17 Apr 2020 11:40:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RZZaRpi8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730452AbgDQLkl (ORCPT ); Fri, 17 Apr 2020 07:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1730267AbgDQLkk (ORCPT ); Fri, 17 Apr 2020 07:40:40 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CB39C061A0F for ; Fri, 17 Apr 2020 04:40:40 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id r24so1698367ljd.4 for ; Fri, 17 Apr 2020 04:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qhmDZCtu+Fm5vZMBowuSgHazmx5rDHZk1tmwfRDitKM=; b=RZZaRpi8gWQG1wgvVw1SjeDt3fBJO6IUbms7KYFA8QlZ+s13bCT4KAmqdwUPZ8lHbi Z01grjlVT7k1mQ9HEPW0ku2V5alXNwL+tDnSAGW59v0Tdq/nx/5Po8aBXKkUU8c/rkNB 5Snc4xw+oca1QtdnO82t5oHFoRJggPJssl7le2A1J31e4Yo8BhuoRMIa1BMeBGSSEM71 oM/WzyREzsyjY/94NwA/c/bGcdFjUxmlmymo4+9qPTTsHqoqqYpDpAyhFGzZTQ16iVlw 6c5IeXyme4+HP0B1wSN5iPMD9vK9Nc+hOQEiRVOPiJbGzC1nX0FDxKpR0OeVH1Oic9Pc 3ygA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qhmDZCtu+Fm5vZMBowuSgHazmx5rDHZk1tmwfRDitKM=; b=S6MdI6kXbZplb9R8GrSSKlyoLsx1hypoaJ8hbgWMQZUtoZPabk+UCnOjWiJT5sGNzz PiN72qi2hWCfSrzlX/tcxLHh7gr1dzQHIeu+C8c6o7yqz0lhEgm/S/7clAfe7RjL1uIf yZ6fw7vahnM5Cf/CkO6uP0Lksj2FZYceuS8wJRWbWkn3ufALEU+MNhXLnF+08o5sin8Q AkUnNK1kf/uA8FoWGXiaKV1X7ch+JO0fKCav5jJWCjByxfmAesdx/6h/XQ9PEvicpzzf CzJfTG9rXDjDich0MQD35SGhtUB4MCTkYrgwJIl70iiL8NplXGeC0hrHxCngepOXH3i7 5XMw== X-Gm-Message-State: AGi0PuYE7vWAvvXJ7yrt57R2KbXPobc/T7kosKzXOr8XPpHhMjGCeJl+ yoxCSQieBF5Pln4xhtLzjaDsWOUHplk= X-Google-Smtp-Source: APiQypJTFnI7d2Jl1UvXuhJNx+Zk9Xzq51U1c3/EqRmHjG0E42ZwxGFDGbja412Z8LwUAU4UPGhYpQ== X-Received: by 2002:a05:651c:1209:: with SMTP id i9mr1720176lja.250.1587123638595; Fri, 17 Apr 2020 04:40:38 -0700 (PDT) Received: from localhost.bredbandsbolaget (c-f3d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.243]) by smtp.gmail.com with ESMTPSA id 78sm16256618ljf.76.2020.04.17.04.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 04:40:38 -0700 (PDT) From: Linus Walleij To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-input@vger.kernel.org, Linus Walleij , Nick Reitemeyer , Stephan Gerhold , =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= Subject: [PATCH 3/3 v3] iio: magnetometer: ak8974: Provide scaling Date: Fri, 17 Apr 2020 13:40:20 +0200 Message-Id: <20200417114020.31291-3-linus.walleij@linaro.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200417114020.31291-1-linus.walleij@linaro.org> References: <20200417114020.31291-1-linus.walleij@linaro.org> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org The manual for the HSCDTD008A gives us a scaling for the three axis as +/- 2.4mT (24 Gauss) per axis. The manual for the AMI305 and AMI306 gives us a scaling for the three axis as +/- 12 Gauss per axis. Tests with the HSCDTD008A sensor, cat the raw values: $ cat in_magn_*_raw raw 45 189 -19 The scaling factor in in_magn_*_scale is 0.001464843, which gives: 0.065 Gauss 0.277 Gauss -0.027 Gauss The earths magnetic field is in the range of 0.25 to 0.65 Gauss on the surface according to Wikipedia, so these seem like reasonable values. Again we are guessing that the AK8974 has a 12 bit ADC, based on the similarity with AMI305 and AMI306. Cc: Nick Reitemeyer Cc: Stephan Gerhold Cc: Michał Mirosław Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Scale the 2.4mT/24Gauss to 15 bits for the HSCDTD008A. - Scale the 12 Gauss to 12 bits for the AMI305/AMI306 - Use 12 bits for the other variants. - Return directly in the raw read function. ChangeLog v1->v2: - Split out the measurement refactoring. --- drivers/iio/magnetometer/ak8974.c | 45 ++++++++++++++++++++++++++++++- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c index b8dbea119a67..f8410ac34316 100644 --- a/drivers/iio/magnetometer/ak8974.c +++ b/drivers/iio/magnetometer/ak8974.c @@ -608,6 +608,48 @@ static int ak8974_read_raw(struct iio_dev *indio_dev, if (ret) return ret; return IIO_VAL_INT; + case IIO_CHAN_INFO_SCALE: + switch (ak8974->variant) { + case AK8974_WHOAMI_VALUE_AMI306: + case AK8974_WHOAMI_VALUE_AMI305: + /* + * The datasheet for AMI305 and AMI306, page 6 + * specifies the range of the sensor to be + * +/- 12 Gauss. + */ + *val = 12 * 2; + /* + * 12 bits are used + * [ -2048 .. 2047 ] (manual page 20) + * [ 0xf800 .. 0x07ff ] + */ + *val2 = 4096; + return IIO_VAL_FRACTIONAL; + case AK8974_WHOAMI_VALUE_HSCDTD008A: + /* + * The datasheet for HSCDTF008A, page 3 specifies the + * range of the sensor as +/- 2.4 mT per axis, which + * corresponds to +/- 2400 uT = +/- 24 Gauss. + */ + *val = 24 * 2; + /* + * 15 bits are used (set up in CTRL4) + * [ -16384 .. 16383 ] (manual page 24) + * [ 0xc000 .. 0x3fff ] + */ + *val2 = 32768; + return IIO_VAL_FRACTIONAL; + default: + /* GUESSING +/- 12 Gauss */ + *val = 12 * 2; + /* GUESSING 12 bits ADC */ + *val2 = 4096; + return IIO_VAL_FRACTIONAL; + } + break; + default: + /* Unknown request */ + break; } return -EINVAL; @@ -672,7 +714,8 @@ static const struct iio_chan_spec_ext_info ak8974_ext_info[] = { .type = IIO_MAGN, \ .modified = 1, \ .channel2 = IIO_MOD_##axis, \ - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ + BIT(IIO_CHAN_INFO_SCALE), \ .ext_info = ak8974_ext_info, \ .address = index, \ .scan_index = index, \