| Message ID | 20200506110445.111576-1-chentao107@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] input/keyboard/qt1050: fix unsigned comparison with 0 | expand |
diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c index 403060d05c3b..a9ac99f62e39 100644 --- a/drivers/input/keyboard/qt1050.c +++ b/drivers/input/keyboard/qt1050.c @@ -368,7 +368,7 @@ static int qt1050_parse_fw(struct qt1050_priv *ts) dev_err(dev, "Button without pad number\n"); goto err; } - if (button.num < 0 || button.num > QT1050_MAX_KEYS - 1) + if (button.num > QT1050_MAX_KEYS - 1) goto err; ts->reg_keys |= BIT(button.num);
Fixes warning because num is u32 and can never be negtative drivers/input/keyboard/qt1050.c:371:18: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if (button.num < 0 || button.num > QT1050_MAX_KEYS - 1) Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: ChenTao <chentao107@huawei.com> --- drivers/input/keyboard/qt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)