| Message ID | 20200615204914.15549-1-fed.ricchiuto@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 43e666acb79f3d355dd89bf20f4d25d3b15da13e |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override | expand |
Hi, On 6/15/20 10:49 PM, Federico Ricchiuto wrote: > The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does > not supply descriptors, so it has to be added to the override list. > > Signed-off-by: Federico Ricchiuto <fed.ricchiuto@gmail.com> It looks like you copied and pasted part of the commit message from another patch (which is fine), but you need to update the Subject (the first line of the commit message) the Subject now still mentions the Trekstor Surfbook E11B rather then the Mediacom FlexBook edge13. Otherwise this looks good to me. Regards, Hans > --- > drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c > index a66f08041a1a..bb3f802935cc 100644 > --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c > +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c > @@ -373,6 +373,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = { > }, > .driver_data = (void *)&sipodev_desc > }, > + { > + .ident = "Mediacom FlexBook edge 13", > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MEDIACOM"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FlexBook_edge13-M-FBE13"), > + }, > + .driver_data = (void *)&sipodev_desc > + }, > { > .ident = "Odys Winbook 13", > .matches = { >
On Tue, 16 Jun 2020, Hans de Goede wrote: > Hi, > > On 6/15/20 10:49 PM, Federico Ricchiuto wrote: > > The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does > > not supply descriptors, so it has to be added to the override list. > > > > Signed-off-by: Federico Ricchiuto <fed.ricchiuto@gmail.com> > > It looks like you copied and pasted part of the commit message from > another patch (which is fine), but you need to update the Subject > (the first line of the commit message) the Subject now still > mentions the Trekstor Surfbook E11B rather then the > Mediacom FlexBook edge13. > > Otherwise this looks good to me. Thanks. I've fixed up the subject and applied.
diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c index a66f08041a1a..bb3f802935cc 100644 --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c @@ -373,6 +373,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = { }, .driver_data = (void *)&sipodev_desc }, + { + .ident = "Mediacom FlexBook edge 13", + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MEDIACOM"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FlexBook_edge13-M-FBE13"), + }, + .driver_data = (void *)&sipodev_desc + }, { .ident = "Odys Winbook 13", .matches = {
The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does not supply descriptors, so it has to be added to the override list. Signed-off-by: Federico Ricchiuto <fed.ricchiuto@gmail.com> --- drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++ 1 file changed, 8 insertions(+)