| Message ID | 20200703143457.132373-1-me@0upti.me (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | dcb00fc799dc03fd320e123e4c81b3278c763ea5 |
| Headers | show |
| Series | input/synaptics: enable InterTouch for ThinkPad X1E 1st gen | expand |
FWIW it's not placebo, it's why I always immediately notice when starting up a new ThinkPad sample from lenovo if RMI4 is enabled or not :). Anyway thank you for the patch, assuming you double-checked that clicking with the clickpad still works (I made this mistake last time when trying to enable this for the second generation X1 extreme): Reviewed-by: Lyude Paul <lyude@redhat.com> On Fri, 2020-07-03 at 17:34 +0300, K900 wrote: > From: Ilya Katsnelson <me@0upti.me> > > Tested on my own laptop, touchpad feels slightly more responsive with > this on, though it might just be placebo. > > Signed-off-by: Ilya Katsnelson <me@0upti.me> > --- > drivers/input/mouse/synaptics.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index 758dae8d6500..4b81b2d0fe06 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = { > "LEN0093", /* T480 */ > "LEN0096", /* X280 */ > "LEN0097", /* X280 -> ALPS trackpoint */ > + "LEN0099", /* X1 Extreme 1st */ > "LEN009b", /* T580 */ > "LEN200f", /* T450s */ > "LEN2044", /* L470 */
(sorry for resending - the previous message got sent as HTML and bounced off the mailing list) This actually made me retest it just now - it most definitely works, both by tapping and by actually clicking the button. 06.07.2020, 20:22, "Lyude Paul" <lyude@redhat.com>: > FWIW it's not placebo, it's why I always immediately notice when starting up a > new ThinkPad sample from lenovo if RMI4 is enabled or not :). > > Anyway thank you for the patch, assuming you double-checked that clicking with > the clickpad still works (I made this mistake last time when trying to enable > this for the second generation X1 extreme): > > Reviewed-by: Lyude Paul <lyude@redhat.com> > > On Fri, 2020-07-03 at 17:34 +0300, K900 wrote: >> From: Ilya Katsnelson <me@0upti.me> >> >> Tested on my own laptop, touchpad feels slightly more responsive with >> this on, though it might just be placebo. >> >> Signed-off-by: Ilya Katsnelson <me@0upti.me> >> --- >> drivers/input/mouse/synaptics.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c >> index 758dae8d6500..4b81b2d0fe06 100644 >> --- a/drivers/input/mouse/synaptics.c >> +++ b/drivers/input/mouse/synaptics.c >> @@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = { >> "LEN0093", /* T480 */ >> "LEN0096", /* X280 */ >> "LEN0097", /* X280 -> ALPS trackpoint */ >> + "LEN0099", /* X1 Extreme 1st */ >> "LEN009b", /* T580 */ >> "LEN200f", /* T450s */ >> "LEN2044", /* L470 */
On Fri, Jul 03, 2020 at 05:34:55PM +0300, K900 wrote: > From: Ilya Katsnelson <me@0upti.me> > > Tested on my own laptop, touchpad feels slightly more responsive with > this on, though it might just be placebo. > > Signed-off-by: Ilya Katsnelson <me@0upti.me> Applied, thank you.
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 758dae8d6500..4b81b2d0fe06 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = { "LEN0093", /* T480 */ "LEN0096", /* X280 */ "LEN0097", /* X280 -> ALPS trackpoint */ + "LEN0099", /* X1 Extreme 1st */ "LEN009b", /* T580 */ "LEN200f", /* T450s */ "LEN2044", /* L470 */