| Message ID | 20200720092148.9320-1-wangxiongfeng2@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 37bd9e803daea816f2dc2c8f6dc264097eb3ebd2 |
| Headers | show |
| Series | Input: ati_remote2 - add missing newlines when printing module parameters | expand |
On Mon, Jul 20, 2020 at 05:21:48PM +0800, Xiongfeng Wang wrote: > When I cat some module parameters by sysfs, it displays as follows. It's > better to add a newline for easy reading. > > root@syzkaller:~# cat /sys/module/ati_remote2/parameters/mode_mask > 0x1froot@syzkaller:~# cat /sys/module/ati_remote2/parameters/channel_mask > 0xffffroot@syzkaller:~# > > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> Applied, thank you.
diff --git a/drivers/input/misc/ati_remote2.c b/drivers/input/misc/ati_remote2.c index 305f0160506a..8a36d78fed63 100644 --- a/drivers/input/misc/ati_remote2.c +++ b/drivers/input/misc/ati_remote2.c @@ -68,7 +68,7 @@ static int ati_remote2_get_channel_mask(char *buffer, { pr_debug("%s()\n", __func__); - return sprintf(buffer, "0x%04x", *(unsigned int *)kp->arg); + return sprintf(buffer, "0x%04x\n", *(unsigned int *)kp->arg); } static int ati_remote2_set_mode_mask(const char *val, @@ -84,7 +84,7 @@ static int ati_remote2_get_mode_mask(char *buffer, { pr_debug("%s()\n", __func__); - return sprintf(buffer, "0x%02x", *(unsigned int *)kp->arg); + return sprintf(buffer, "0x%02x\n", *(unsigned int *)kp->arg); } static unsigned int channel_mask = ATI_REMOTE2_MAX_CHANNEL_MASK;
When I cat some module parameters by sysfs, it displays as follows. It's better to add a newline for easy reading. root@syzkaller:~# cat /sys/module/ati_remote2/parameters/mode_mask 0x1froot@syzkaller:~# cat /sys/module/ati_remote2/parameters/channel_mask 0xffffroot@syzkaller:~# Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> --- drivers/input/misc/ati_remote2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)