From patchwork Wed Aug 26 18:17:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11739329 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CAB271731 for ; Wed, 26 Aug 2020 18:19:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3AF720737 for ; Wed, 26 Aug 2020 18:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598465979; bh=/FkqaqIXZzbXcSTu05JXN8zxrYdqxFmLMeqEbZbaSRA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BHXMApwoWsDaaK9v1dPfBsPWA59XWlup7HZe94oVaVZjsvM3N/mBMhVe5aGZLySzV LTO3ejm03IMpFlCym5c63D/Wme/Ylt/taRgvWZKJUqFSovRqTBzlhwBzo8hyyMDUZt A1SdB6l5uwaBkvMf826/IeT0MFtqMET3UQT48Ekc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727926AbgHZSS4 (ORCPT ); Wed, 26 Aug 2020 14:18:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:43336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727919AbgHZSSy (ORCPT ); Wed, 26 Aug 2020 14:18:54 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63936207BC; Wed, 26 Aug 2020 18:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598465934; bh=/FkqaqIXZzbXcSTu05JXN8zxrYdqxFmLMeqEbZbaSRA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=06p6JI0CrZMQzNjpp2j1O2a/1td+bpk6bQoJR98SDTin+KM7qKpyiQ7lCPL8UJG/B yaVugQ9q9hBo2021b97piey1GLeGcmVphlu8oozFilhbpNMgGd4VXF3XyyzhAD3VzB iYboRS5ZSDDIAR35JXMqx8UQXvX3fainUSrUJizk= From: Krzysztof Kozlowski To: Dmitry Torokhov , Hans de Goede , Linus Walleij , Bastien Nocera , Sangwon Jee , Eugen Hristev , "Gustavo A. R. Silva" , Andy Shevchenko , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 23/24] Input: surface3_spi - Simplify with dev_err_probe() Date: Wed, 26 Aug 2020 20:17:05 +0200 Message-Id: <20200826181706.11098-23-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200826181706.11098-1-krzk@kernel.org> References: <20200826181706.11098-1-krzk@kernel.org> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Andy Shevchenko --- drivers/input/touchscreen/surface3_spi.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c index ce4828b1415a..25bb77ddf2ef 100644 --- a/drivers/input/touchscreen/surface3_spi.c +++ b/drivers/input/touchscreen/surface3_spi.c @@ -223,7 +223,6 @@ static void surface3_spi_power(struct surface3_ts_data *data, bool on) */ static int surface3_spi_get_gpio_config(struct surface3_ts_data *data) { - int error; struct device *dev; struct gpio_desc *gpiod; int i; @@ -233,15 +232,9 @@ static int surface3_spi_get_gpio_config(struct surface3_ts_data *data) /* Get the reset lines GPIO pin number */ for (i = 0; i < 2; i++) { gpiod = devm_gpiod_get_index(dev, NULL, i, GPIOD_OUT_LOW); - if (IS_ERR(gpiod)) { - error = PTR_ERR(gpiod); - if (error != -EPROBE_DEFER) - dev_err(dev, - "Failed to get power GPIO %d: %d\n", - i, - error); - return error; - } + if (IS_ERR(gpiod)) + return dev_err_probe(dev, PTR_ERR(gpiod), + "Failed to get power GPIO %d\n", i); data->gpiod_rst[i] = gpiod; }