| Message ID | 20201126133607.3212484-2-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
| Series | Rid W=1 issues from Input | expand |
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 8fb7b4385ded9..3cc8b76629fa2 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -1106,8 +1106,11 @@ static void synaptics_process_packet(struct psmouse *psmouse) num_fingers = hw.w + 2; break; case 2: - if (SYN_MODEL_PEN(info->model_id)) - ; /* Nothing, treat a pen as a single finger */ + /* + * Keep defaults + * + * SYN_MODEL_PEN: Treat pens as a single finger + */ break; case 4 ... 15: if (SYN_CAP_PALMDETECT(info->capabilities))
Fixes the following W=1 kernel build warning(s): drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’: drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Henrik Rydberg <rydberg@bitmath.org> Cc: Peter Osterlund <petero2@telia.com> Cc: Stefan Gmeiner <riddlebox@freesurf.ch> Cc: "C. Scott Ananian" <cananian@alumni.priceton.edu> Cc: Bruce Kalk <kall@compass.com> Cc: this to <linux-input@vger.kernel.org> Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/input/mouse/synaptics.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)