| Message ID | 20210301234928.4298-2-jeff@labundy.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 374b4b7abc4765749f662801dfa147cc8cc67a70 |
| Headers | show |
| Series | Add support for Azoteq IQS626A | expand |
On Mon, Mar 01, 2021 at 05:49:25PM -0600, Jeff LaBundy wrote: > Some devices outside of drivers/input/touchscreen/ can still make > use of the touchscreen helper functions. Therefore, it was agreed > in [1] to move them outside of drivers/input/touchscreen/ so that > other devices can call them without INPUT_TOUCHSCREEN being set. > > As part of this change, 'of' is dropped from the filename because > the helpers no longer actually use OF. No changes are made to the > file contents whatsoever. > > Based on the feedback in [2], the corresponding binding documents > (touchscreen.yaml and touchscreen.txt) are left in their original > locations. > > [1] https://patchwork.kernel.org/patch/11924029/ > [2] https://patchwork.kernel.org/patch/12042037/ > > Signed-off-by: Jeff LaBundy <jeff@labundy.com> Applied, thank you.
diff --git a/drivers/input/Makefile b/drivers/input/Makefile index d8f5310e22ba..037cc595106c 100644 --- a/drivers/input/Makefile +++ b/drivers/input/Makefile @@ -7,6 +7,7 @@ obj-$(CONFIG_INPUT) += input-core.o input-core-y := input.o input-compat.o input-mt.o input-poller.o ff-core.o +input-core-y += touchscreen.o obj-$(CONFIG_INPUT_FF_MEMLESS) += ff-memless.o obj-$(CONFIG_INPUT_SPARSEKMAP) += sparse-keymap.o diff --git a/drivers/input/touchscreen/of_touchscreen.c b/drivers/input/touchscreen.c similarity index 100% rename from drivers/input/touchscreen/of_touchscreen.c rename to drivers/input/touchscreen.c diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index 529614d364fe..aead3ad6ba6a 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -12,10 +12,6 @@ menuconfig INPUT_TOUCHSCREEN if INPUT_TOUCHSCREEN -config TOUCHSCREEN_PROPERTIES - def_tristate INPUT - depends on INPUT - config TOUCHSCREEN_88PM860X tristate "Marvell 88PM860x touchscreen" depends on MFD_88PM860X diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile index 6233541e9173..80cd241b4c1b 100644 --- a/drivers/input/touchscreen/Makefile +++ b/drivers/input/touchscreen/Makefile @@ -7,7 +7,6 @@ wm97xx-ts-y := wm97xx-core.o -obj-$(CONFIG_TOUCHSCREEN_PROPERTIES) += of_touchscreen.o obj-$(CONFIG_TOUCHSCREEN_88PM860X) += 88pm860x-ts.o obj-$(CONFIG_TOUCHSCREEN_AD7877) += ad7877.o obj-$(CONFIG_TOUCHSCREEN_AD7879) += ad7879.o
Some devices outside of drivers/input/touchscreen/ can still make use of the touchscreen helper functions. Therefore, it was agreed in [1] to move them outside of drivers/input/touchscreen/ so that other devices can call them without INPUT_TOUCHSCREEN being set. As part of this change, 'of' is dropped from the filename because the helpers no longer actually use OF. No changes are made to the file contents whatsoever. Based on the feedback in [2], the corresponding binding documents (touchscreen.yaml and touchscreen.txt) are left in their original locations. [1] https://patchwork.kernel.org/patch/11924029/ [2] https://patchwork.kernel.org/patch/12042037/ Signed-off-by: Jeff LaBundy <jeff@labundy.com> --- Changes in v3: - Updated the commit message to reference the discussion over the bindings Changes in v2: - Added this patch to the series drivers/input/Makefile | 1 + drivers/input/{touchscreen/of_touchscreen.c => touchscreen.c} | 0 drivers/input/touchscreen/Kconfig | 4 ---- drivers/input/touchscreen/Makefile | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) rename drivers/input/{touchscreen/of_touchscreen.c => touchscreen.c} (100%) -- 2.17.1