From patchwork Fri Mar 5 02:03:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 12117393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E439EC433E0 for ; Fri, 5 Mar 2021 02:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FF4B64F4C for ; Fri, 5 Mar 2021 02:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229478AbhCECDx (ORCPT ); Thu, 4 Mar 2021 21:03:53 -0500 Received: from mail2.protonmail.ch ([185.70.40.22]:27720 "EHLO mail2.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbhCECDw (ORCPT ); Thu, 4 Mar 2021 21:03:52 -0500 Date: Fri, 05 Mar 2021 02:03:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1614909830; bh=GduqeEmhvsNKh/mBiEjO2HT/vpt87Bd8VyVcvhIY1Kg=; h=Date:To:From:Cc:Reply-To:Subject:From; b=m8FWBaot3PepJ8Y03N2zE0ipJkigXZ3Gu2W+gCse4GH9nPPBQs2egIhMo+f75sHW4 vaZK1XBwEVPsq/8O17MdAdyrKs4kR6S8fkkkpGhDSeaX6smO3T1eMHXsq3MawsqpDb ySXux0ch/J2ktTseMbVJi/SJ8ZpXA7mjXlEKWCc4= To: caleb@connolly.tech, andi@etezian.org, Dmitry Torokhov From: Caleb Connolly Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Caleb Connolly Subject: [PATCH] input: s6sy761: fix coordinate read bit shift Message-ID: <20210305020310.550527-1-caleb@connolly.tech> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 The touch coordinates are read by shifting a value left by 3, this is incorrect and effectively causes the coordinates to be half of the correct value. Shift by 4 bits instead to report the correct value. This matches downstream examples, and has been confirmed on my device (OnePlus 7 Pro). Signed-off-by: Caleb Connolly Reviewed-by: Andi Shyti --- drivers/input/touchscreen/s6sy761.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c index b63d7fdf0cd2..85a1f465c097 100644 --- a/drivers/input/touchscreen/s6sy761.c +++ b/drivers/input/touchscreen/s6sy761.c @@ -145,8 +145,8 @@ static void s6sy761_report_coordinates(struct s6sy761_data *sdata, u8 major = event[4]; u8 minor = event[5]; u8 z = event[6] & S6SY761_MASK_Z; - u16 x = (event[1] << 3) | ((event[3] & S6SY761_MASK_X) >> 4); - u16 y = (event[2] << 3) | (event[3] & S6SY761_MASK_Y); + u16 x = (event[1] << 4) | ((event[3] & S6SY761_MASK_X) >> 4); + u16 y = (event[2] << 4) | (event[3] & S6SY761_MASK_Y); input_mt_slot(sdata->input, tid);