From patchwork Wed Mar 24 17:33:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161901 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 161E0C433DB for ; Wed, 24 Mar 2021 17:35:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5B61619F3 for ; Wed, 24 Mar 2021 17:35:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237170AbhCXRej (ORCPT ); Wed, 24 Mar 2021 13:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237209AbhCXReL (ORCPT ); Wed, 24 Mar 2021 13:34:11 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C72DC0613DF for ; Wed, 24 Mar 2021 10:34:11 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id e14so16030899ejz.11 for ; Wed, 24 Mar 2021 10:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tQ98DqDCgp3VpW9J5G14oAPOoDjqdZPJlI/Mwh4Jc20=; b=A/dLEQ9uqTQQWDf+7m1HxFqs9w2URyTdEjwP4HueRVEUEatZ8pYoCvHmFemsWVs9d7 i/DOxyZUkBOR2x9Tp9Oxx2iUas5mjtYD+WtHclWhipLhDzuX6kQiMNqlBiuBttAssi2/ 3fkSdK2UqkJsS1XgsxuzwQH8GSmuJ788TgPlQE2All5vCLHGoFzxQGzCPs21YgGt6yZE OENgn3K7kKtgFXgccsbt4RKXlVvbsIL3brWTgpYq6ciFhPtpN6iam1J8cXdy5JOon7/r ILH7NlB3ivsps1WTPT9VZBpr/TpPKE6etLm9d5/8QPpWR7E6CurDEAbyjtAXsKqQCxGN 1F5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tQ98DqDCgp3VpW9J5G14oAPOoDjqdZPJlI/Mwh4Jc20=; b=ppcsjacMmmHMwEYSB2Xd4I3eW+SR7sSEj0AP125wqR830Ua2ufLhaWb9eZQjAx/SjI dUx4y1pQr6caxuOzReAwrf3iN/B7wDT3eMI+HodnwLIlGWYu8kv2U/TkQRCisFJPrxlW +CoeQyBhNN6VQayXy+p1iJ6s4FzdeXAFn91sRvyVCfHm/Zk16j4l0jj+3Y7B+/iG8zH4 2lfVAKn+MQL/PHSSvLm21+QEUpTT8y7SeKXwkemTpoSyF8y4CyGafYDH7QTYPW93rcsB +Cb+NHhCGuV7rfRHqwElCj3EGhT35y+mXeu6VaJjMsUOlXV2mmnE4ycIhFg9khbSIwih ciLw== X-Gm-Message-State: AOAM5332FZRPQjzpG72uDH/rSG7KkRIXAXwh6JYgfh4jizs6GlY5rVYt hXeNJhJmezpfbiDdqBWZ33xlAw== X-Google-Smtp-Source: ABdhPJxYd5PUfyNZIS4zpjgDLCdEncag5+bFQ6PaVo8gsvofMOve1KaZeAUJPzuvz6cPq6tcBPXTEg== X-Received: by 2002:a17:906:938f:: with SMTP id l15mr4872399ejx.15.1616607250150; Wed, 24 Mar 2021 10:34:10 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:09 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Daniel Drubin , linux-input@vger.kernel.org Subject: [PATCH 02/25] HID: ishtp-hid-client: Move variable to where it's actually used Date: Wed, 24 Mar 2021 17:33:41 +0000 Message-Id: <20210324173404.66340-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11: drivers/hid/intel-ish-hid/ishtp-hid.h:24:21: warning: ‘hid_ishtp_guid’ defined but not used [-Wunused-const-variable=] Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Daniel Drubin Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 +++++ drivers/hid/intel-ish-hid/ishtp-hid.h | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 0f1b5283bab42..24599280105d8 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c @@ -11,6 +11,11 @@ #include #include "ishtp-hid.h" +/* ISH Transport protocol (ISHTP in short) GUID */ +static const guid_t hid_ishtp_guid = + GUID_INIT(0x33AECD58, 0xB679, 0x4E54, + 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26); + /* Rx ring buffer pool size */ #define HID_CL_RX_RING_SIZE 32 #define HID_CL_TX_RING_SIZE 16 diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.h b/drivers/hid/intel-ish-hid/ishtp-hid.h index 5ffd0da3cf1fa..e2423f7d2b547 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.h +++ b/drivers/hid/intel-ish-hid/ishtp-hid.h @@ -20,11 +20,6 @@ extern void (*hid_print_trace)(void *unused, const char *format, ...); #define hid_ishtp_trace(client, ...) \ (hid_print_trace)(NULL, __VA_ARGS__) -/* ISH Transport protocol (ISHTP in short) GUID */ -static const guid_t hid_ishtp_guid = - GUID_INIT(0x33AECD58, 0xB679, 0x4E54, - 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26); - /* ISH HID message structure */ struct hostif_msg_hdr { uint8_t command; /* Bit 7: is_response */