| Message ID | 20210615103014.798-3-alistair@alistair23.me (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Wacom I2C support to rM2 | expand |
Hi Alistair, On Tue, Jun 15, 2021 at 08:30:07PM +1000, Alistair Francis wrote: > Signed-off-by: Alistair Francis <alistair@alistair23.me> Please also send DT bindings to Rob Herring <robh+dt@kernel.org> and devicetree@vger.kernel.org. > --- > .../input/touchscreen/wacom,generic.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml > new file mode 100644 > index 000000000000..68f3f5271b77 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/wacom,generic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Wacom I2C Controller > + > +maintainers: > + - Alistair Francis <alistair@alistair23.me> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + const: wacom,generic This is not an acceptable DT compatible. This needs to be a particular model of the controller, preferably the first one that supports this protocol. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: > + description: Power Supply > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include "dt-bindings/interrupt-controller/irq.h" > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + digitiser@9 { > + compatible = "wacom,generic"; > + reg = <0x9>; > + interrupt-parent = <&gpio1>; > + interrupts = <9 IRQ_TYPE_LEVEL_LOW>; > + vdd-supply = <®_touch>; > + }; > + }; > -- > 2.31.1 > Thanks.
diff --git a/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml new file mode 100644 index 000000000000..68f3f5271b77 --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/wacom,generic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Wacom I2C Controller + +maintainers: + - Alistair Francis <alistair@alistair23.me> + +allOf: + - $ref: touchscreen.yaml# + +properties: + compatible: + const: wacom,generic + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + vdd-supply: + description: Power Supply + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + #include "dt-bindings/interrupt-controller/irq.h" + i2c { + #address-cells = <1>; + #size-cells = <0>; + digitiser@9 { + compatible = "wacom,generic"; + reg = <0x9>; + interrupt-parent = <&gpio1>; + interrupts = <9 IRQ_TYPE_LEVEL_LOW>; + vdd-supply = <®_touch>; + }; + };
Signed-off-by: Alistair Francis <alistair@alistair23.me> --- .../input/touchscreen/wacom,generic.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml