diff mbox series

fix Touchscreen X Axis inversion on Trekstor Surftab W1

Message ID 20210626065417.8818-1-schu.ju@gmx.net (mailing list archive)
State Under Review
Headers show
Series fix Touchscreen X Axis inversion on Trekstor Surftab W1 | expand

Commit Message

Julian Schulte June 26, 2021, 6:54 a.m. UTC
Signed-off-by: Julian Schulte <schu.ju@gmx.net>
---
 drivers/input/touchscreen/goodix.c | 7 +++++++
 1 file changed, 7 insertions(+)

--
2.30.2

Comments

Dmitry Torokhov April 17, 2022, 8:25 p.m. UTC | #1
On Sat, Jun 26, 2021 at 08:54:17AM +0200, Julian Schulte wrote:

Just found it in my inbox. Adding Hans...

> Signed-off-by: Julian Schulte <schu.ju@gmx.net>
> ---
>  drivers/input/touchscreen/goodix.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index c682b028f..cec5f7bdc 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -248,6 +248,13 @@ static const struct dmi_system_id inverted_x_screen[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "I15-TC")
>  		},
>  	},
> +	{
> +		.ident = "TrekStor SurfTab duo W1 10.1 (VT4)",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "TrekStor"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "SurfTab duo W1 10.1 (VT4)")
> +		},
> +	},
>  #endif
>  	{}
>  };
> --
> 2.30.2
>
Dmitry Torokhov April 17, 2022, 8:29 p.m. UTC | #2
On Sun, Apr 17, 2022 at 01:25:33PM -0700, Dmitry Torokhov wrote:
> On Sat, Jun 26, 2021 at 08:54:17AM +0200, Julian Schulte wrote:
> 
> Just found it in my inbox. Adding Hans...

For real this time...

> 
> > Signed-off-by: Julian Schulte <schu.ju@gmx.net>
> > ---
> >  drivers/input/touchscreen/goodix.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> > index c682b028f..cec5f7bdc 100644
> > --- a/drivers/input/touchscreen/goodix.c
> > +++ b/drivers/input/touchscreen/goodix.c
> > @@ -248,6 +248,13 @@ static const struct dmi_system_id inverted_x_screen[] = {
> >  			DMI_MATCH(DMI_PRODUCT_NAME, "I15-TC")
> >  		},
> >  	},
> > +	{
> > +		.ident = "TrekStor SurfTab duo W1 10.1 (VT4)",
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "TrekStor"),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "SurfTab duo W1 10.1 (VT4)")
> > +		},
> > +	},
> >  #endif
> >  	{}
> >  };
> > --
> > 2.30.2
> > 
> 
> -- 
> Dmitry
Hans de Goede April 18, 2022, 2:38 p.m. UTC | #3
Hi Dmitry, Julian,

On 4/18/22 11:41, Julian Schulte wrote:
> Hi, 
> I think this is already solved by another patch. At least I tested in the meantime and the bug was not present anymore. 

Correct, this was fixed by this patch:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a274cd66bc6461b45a450cd3f5653473a9aaea75

Regards,

Hans


> Dmitry Torokhov <dmitry.torokhov@gmail.com <mailto:dmitry.torokhov@gmail.com>> schrieb am So., 17. Apr. 2022, 22:29:
> 
>     On Sun, Apr 17, 2022 at 01:25:33PM -0700, Dmitry Torokhov wrote:
>     > On Sat, Jun 26, 2021 at 08:54:17AM +0200, Julian Schulte wrote:
>     >
>     > Just found it in my inbox. Adding Hans...
> 
>     For real this time...
> 
>     >
>     > > Signed-off-by: Julian Schulte <schu.ju@gmx.net <mailto:schu.ju@gmx.net>>
>     > > ---
>     > >  drivers/input/touchscreen/goodix.c | 7 +++++++
>     > >  1 file changed, 7 insertions(+)
>     > >
>     > > diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
>     > > index c682b028f..cec5f7bdc 100644
>     > > --- a/drivers/input/touchscreen/goodix.c
>     > > +++ b/drivers/input/touchscreen/goodix.c
>     > > @@ -248,6 +248,13 @@ static const struct dmi_system_id inverted_x_screen[] = {
>     > >                     DMI_MATCH(DMI_PRODUCT_NAME, "I15-TC")
>     > >             },
>     > >     },
>     > > +   {
>     > > +           .ident = "TrekStor SurfTab duo W1 10.1 (VT4)",
>     > > +           .matches = {
>     > > +                   DMI_MATCH(DMI_SYS_VENDOR, "TrekStor"),
>     > > +                   DMI_MATCH(DMI_PRODUCT_NAME, "SurfTab duo W1 10.1 (VT4)")
>     > > +           },
>     > > +   },
>     > >  #endif
>     > >     {}
>     > >  };
>     > > --
>     > > 2.30.2
>     > >
>     >
>     > --
>     > Dmitry
> 
>     -- 
>     Dmitry
>
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index c682b028f..cec5f7bdc 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -248,6 +248,13 @@  static const struct dmi_system_id inverted_x_screen[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "I15-TC")
 		},
 	},
+	{
+		.ident = "TrekStor SurfTab duo W1 10.1 (VT4)",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TrekStor"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "SurfTab duo W1 10.1 (VT4)")
+		},
+	},
 #endif
 	{}
 };