diff mbox series

[2/3] HID: thrustmaster: Fix memory leak in remove

Message ID 20210730165110.24667-2-novikov@ispras.ru (mailing list archive)
State Mainlined
Commit df3a97bdbc252d3421f1c5d6d713ad6e4f36a469
Delegated to: Jiri Kosina
Headers show
Series [1/3] HID: thrustmaster: Fix memory leaks in probe | expand

Commit Message

Evgeny Novikov July 30, 2021, 4:51 p.m. UTC
thrustmaster_remove() does not release memory for
tm_wheel->change_request. This is fixed by the patch.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
---
 drivers/hid/hid-thrustmaster.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
index e94d3409fd10..9cb4248f95af 100644
--- a/drivers/hid/hid-thrustmaster.c
+++ b/drivers/hid/hid-thrustmaster.c
@@ -253,6 +253,7 @@  static void thrustmaster_remove(struct hid_device *hdev)
 
 	usb_kill_urb(tm_wheel->urb);
 
+	kfree(tm_wheel->change_request);
 	kfree(tm_wheel->response);
 	kfree(tm_wheel->model_request);
 	usb_free_urb(tm_wheel->urb);