| Message ID | 20210916153403.14999-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Input: regulator-haptic - Make use of the helper function dev_err_probe() | expand |
diff --git a/drivers/input/misc/regulator-haptic.c b/drivers/input/misc/regulator-haptic.c index a661e77545c5..6e6f1a390a00 100644 --- a/drivers/input/misc/regulator-haptic.c +++ b/drivers/input/misc/regulator-haptic.c @@ -169,10 +169,9 @@ static int regulator_haptic_probe(struct platform_device *pdev) } haptic->regulator = devm_regulator_get_exclusive(&pdev->dev, "haptic"); - if (IS_ERR(haptic->regulator)) { - dev_err(&pdev->dev, "failed to get regulator\n"); - return PTR_ERR(haptic->regulator); - } + if (IS_ERR(haptic->regulator)) + return dev_err_probe(&pdev->dev, PTR_ERR(haptic->regulator), + "failed to get regulator\n"); input_dev = devm_input_allocate_device(&pdev->dev); if (!input_dev)
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/input/misc/regulator-haptic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)