| Message ID | 20211012013735.3523140-1-dmitry.torokhov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] Input: ep93xx_keypad - annotate suspend/resume as __maybe_unused | expand |
Hi! On Mon, 2021-10-11 at 18:37 -0700, Dmitry Torokhov wrote: > Instead of guarding suspend/resume methods with #ifdef CONFIG_PM > let's mark them as __maybe_unused as this allows better compile > coverage. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> > --- > drivers/input/keyboard/ep93xx_keypad.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c > index e0e931e796fa..a0c6cdf8e0d3 100644 > --- a/drivers/input/keyboard/ep93xx_keypad.c > +++ b/drivers/input/keyboard/ep93xx_keypad.c > @@ -175,8 +175,7 @@ static void ep93xx_keypad_close(struct input_dev *pdev) > } > > > -#ifdef CONFIG_PM_SLEEP > -static int ep93xx_keypad_suspend(struct device *dev) > +static int __maybe_unused ep93xx_keypad_suspend(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); > @@ -197,7 +196,7 @@ static int ep93xx_keypad_suspend(struct device *dev) > return 0; > } > > -static int ep93xx_keypad_resume(struct device *dev) > +static int __maybe_unused ep93xx_keypad_resume(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); > @@ -220,7 +219,6 @@ static int ep93xx_keypad_resume(struct device *dev) > > return 0; > } > -#endif > > static SIMPLE_DEV_PM_OPS(ep93xx_keypad_pm_ops, > ep93xx_keypad_suspend, ep93xx_keypad_resume);
diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c index e0e931e796fa..a0c6cdf8e0d3 100644 --- a/drivers/input/keyboard/ep93xx_keypad.c +++ b/drivers/input/keyboard/ep93xx_keypad.c @@ -175,8 +175,7 @@ static void ep93xx_keypad_close(struct input_dev *pdev) } -#ifdef CONFIG_PM_SLEEP -static int ep93xx_keypad_suspend(struct device *dev) +static int __maybe_unused ep93xx_keypad_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); @@ -197,7 +196,7 @@ static int ep93xx_keypad_suspend(struct device *dev) return 0; } -static int ep93xx_keypad_resume(struct device *dev) +static int __maybe_unused ep93xx_keypad_resume(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); @@ -220,7 +219,6 @@ static int ep93xx_keypad_resume(struct device *dev) return 0; } -#endif static SIMPLE_DEV_PM_OPS(ep93xx_keypad_pm_ops, ep93xx_keypad_suspend, ep93xx_keypad_resume);
Instead of guarding suspend/resume methods with #ifdef CONFIG_PM let's mark them as __maybe_unused as this allows better compile coverage. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/keyboard/ep93xx_keypad.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)