From patchwork Fri Oct 29 21:55:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Mirabile X-Patchwork-Id: 12593935 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44250C433EF for ; Fri, 29 Oct 2021 21:54:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27AB160FC3 for ; Fri, 29 Oct 2021 21:54:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbhJ2V5L (ORCPT ); Fri, 29 Oct 2021 17:57:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28311 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231397AbhJ2V5J (ORCPT ); Fri, 29 Oct 2021 17:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635544480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t4auqlmjwJ416gp2Ll9qb5ySsLBOgXHPuXf1WS/UfdQ=; b=I1/FEjo1f+nwrD0xr+tjqLBkvrZFgCQK8FSIjcIHZ3Rc7Yiy6KaLFIEJrlb13lSUKavdxI /V1psxayQLUYXoP3FuJE+GSs1OvL8gpkJ89lIKKEoIiDkhnEkwsPW8ySRKRR+fQhb4bjkH xIVzqZ6a2kAagVilUh01I1gWT4wgk+8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-GgVxXltTNvG70rhcLQFUhw-1; Fri, 29 Oct 2021 17:54:36 -0400 X-MC-Unique: GgVxXltTNvG70rhcLQFUhw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4ED1E8018AC; Fri, 29 Oct 2021 21:54:35 +0000 (UTC) Received: from cmirabil.remote.csb (unknown [10.22.8.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id DFD6E5DF56; Fri, 29 Oct 2021 21:54:31 +0000 (UTC) From: Charles Mirabile To: linux-kernel@vger.kernel.org Cc: Charles Mirabile , Dmitry Torokhov , linux-input@vger.kernel.org, Serge Schneider , Stefan Wahren , Nicolas Saenz Julienne , linux-rpi-kernel@lists.infradead.org, fedora-rpi@googlegroups.com, Mwesigwa Guma , Joel Savitz Subject: [PATCH 2/5] drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick driver Date: Fri, 29 Oct 2021 17:55:13 -0400 Message-Id: <20211029215516.801593-3-cmirabil@redhat.com> In-Reply-To: <20211029215516.801593-1-cmirabil@redhat.com> References: <20211029215516.801593-1-cmirabil@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This patch implements support for the joystick. It supports left/right/up/down/enter and is attached via i2c and a gpio pin for irq. Signed-off-by: Charles Mirabile Signed-off-by: Mwesigwa Guma Signed-off-by: Joel Savitz Reported-by: kernel test robot --- drivers/input/joystick/Kconfig | 8 ++ drivers/input/joystick/Makefile | 1 + drivers/input/joystick/sensehat-joystick.c | 135 +++++++++++++++++++++ 3 files changed, 144 insertions(+) create mode 100644 drivers/input/joystick/sensehat-joystick.c diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig index 3b23078bc7b5..d2f78353b74c 100644 --- a/drivers/input/joystick/Kconfig +++ b/drivers/input/joystick/Kconfig @@ -399,4 +399,12 @@ config JOYSTICK_N64 Say Y here if you want enable support for the four built-in controller ports on the Nintendo 64 console. +config JOYSTICK_SENSEHAT + tristate "Raspberry Pi Sense HAT joystick" + depends on GPIOLIB && INPUT + select MFD_SENSEHAT_CORE + + help + This is the joystick driver for the Raspberry Pi Sense HAT + endif diff --git a/drivers/input/joystick/Makefile b/drivers/input/joystick/Makefile index 5174b8aba2dd..39c8b5c6e5ae 100644 --- a/drivers/input/joystick/Makefile +++ b/drivers/input/joystick/Makefile @@ -28,6 +28,7 @@ obj-$(CONFIG_JOYSTICK_N64) += n64joy.o obj-$(CONFIG_JOYSTICK_PSXPAD_SPI) += psxpad-spi.o obj-$(CONFIG_JOYSTICK_PXRC) += pxrc.o obj-$(CONFIG_JOYSTICK_QWIIC) += qwiic-joystick.o +obj-$(CONFIG_JOYSTICK_SENSEHAT) += sensehat-joystick.o obj-$(CONFIG_JOYSTICK_SIDEWINDER) += sidewinder.o obj-$(CONFIG_JOYSTICK_SPACEBALL) += spaceball.o obj-$(CONFIG_JOYSTICK_SPACEORB) += spaceorb.o diff --git a/drivers/input/joystick/sensehat-joystick.c b/drivers/input/joystick/sensehat-joystick.c new file mode 100644 index 000000000000..2a25287b5863 --- /dev/null +++ b/drivers/input/joystick/sensehat-joystick.c @@ -0,0 +1,135 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Raspberry Pi Sense HAT joystick driver + * http://raspberrypi.org + * + * Copyright (C) 2015 Raspberry Pi + * Copyright (C) 2021 Charles Mirabile, Mwesigwa Guma, Joel Savitz + * + * Original Author: Serge Schneider + * Revised for upstream Linux by: Charles Mirabile, Mwesigwa Guma, Joel Savitz + */ + +#include +#include +#include +#include +#include +#include +#include + +#include "sensehat.h" + +int sensehat_get_joystick_state(struct sensehat *sensehat); + +static unsigned char keymap[] = {KEY_DOWN, KEY_RIGHT, KEY_UP, KEY_ENTER, KEY_LEFT,}; + +static irqreturn_t sensehat_joystick_report(int n, void *cookie) +{ + int i; + static s32 prev_keys; + struct sensehat *sensehat = cookie; + struct sensehat_joystick *sensehat_joystick = &sensehat->joystick; + s32 keys = sensehat_get_joystick_state(sensehat); + s32 changes = keys ^ prev_keys; + + prev_keys = keys; + for (i = 0; i < ARRAY_SIZE(keymap); ++i) { + if (changes & (1<keys_dev, + keymap[i], keys & (1<keys_dev); + return IRQ_HANDLED; +} + +static int sensehat_joystick_probe(struct platform_device *pdev) +{ + int ret; + int i; + struct sensehat *sensehat = dev_get_drvdata(&pdev->dev); + struct sensehat_joystick *sensehat_joystick = &sensehat->joystick; + + sensehat_joystick->keys_desc = devm_gpiod_get(&sensehat->i2c_client->dev, + "keys-int", GPIOD_IN); + if (IS_ERR(sensehat_joystick->keys_desc)) { + dev_warn(&pdev->dev, "Failed to get keys-int descriptor.\n"); + return PTR_ERR(sensehat_joystick->keys_desc); + } + + + sensehat_joystick->keys_dev = devm_input_allocate_device(&pdev->dev); + if (!sensehat_joystick->keys_dev) { + dev_err(&pdev->dev, "Could not allocate input device.\n"); + return -ENOMEM; + } + + for (i = 0; i < ARRAY_SIZE(keymap); i++) { + set_bit(keymap[i], + sensehat_joystick->keys_dev->keybit); + } + + sensehat_joystick->keys_dev->name = "Raspberry Pi Sense HAT Joystick"; + sensehat_joystick->keys_dev->phys = "rpi-sense-joy/input0"; + sensehat_joystick->keys_dev->id.bustype = BUS_I2C; + sensehat_joystick->keys_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP); + sensehat_joystick->keys_dev->keycode = keymap; + sensehat_joystick->keys_dev->keycodesize = sizeof(unsigned char); + sensehat_joystick->keys_dev->keycodemax = ARRAY_SIZE(keymap); + + ret = input_register_device(sensehat_joystick->keys_dev); + if (ret) { + dev_err(&pdev->dev, "Could not register input device.\n"); + return ret; + } + + ret = gpiod_direction_input(sensehat_joystick->keys_desc); + if (ret) { + dev_err(&pdev->dev, "Could not set keys-int direction.\n"); + return ret; + } + + sensehat_joystick->keys_irq = gpiod_to_irq(sensehat_joystick->keys_desc); + if (sensehat_joystick->keys_irq < 0) { + dev_err(&pdev->dev, "Could not determine keys-int IRQ.\n"); + return sensehat_joystick->keys_irq; + } + + ret = devm_request_threaded_irq(&pdev->dev, sensehat_joystick->keys_irq, + NULL, sensehat_joystick_report, IRQF_TRIGGER_RISING | IRQF_ONESHOT, + "keys", sensehat); + + if (ret) { + dev_err(&pdev->dev, "IRQ request failed.\n"); + return ret; + } + return 0; +} + +int sensehat_get_joystick_state(struct sensehat *sensehat) +{ + unsigned int reg; + int ret = regmap_read(sensehat->regmap, SENSEHAT_KEYS, ®); + + return ret < 0 ? ret : reg; +} + +static struct platform_device_id sensehat_joystick_device_id[] = { + { .name = "sensehat-joystick" }, + { }, +}; +MODULE_DEVICE_TABLE(platform, sensehat_joystick_device_id); + +static struct platform_driver sensehat_joystick_driver = { + .probe = sensehat_joystick_probe, + .driver = { + .name = "sensehat-joystick", + }, +}; + +module_platform_driver(sensehat_joystick_driver); + +MODULE_DESCRIPTION("Raspberry Pi Sense HAT joystick driver"); +MODULE_AUTHOR("Serge Schneider "); +MODULE_LICENSE("GPL");