| Message ID | 20220302181323.1100490-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 4df4b0fe960c9cbad55d52dbe1b5ced51a2b4fd4 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [next] HID: core: Remove redundant assignment to pointer field | expand |
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index db925794fbe6..6579f4724bbb 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1662,7 +1662,7 @@ static void hid_process_report(struct hid_device *hid, /* first retrieve all incoming values in data */ for (a = 0; a < report->maxfield; a++) - hid_input_fetch_field(hid, field = report->field[a], data); + hid_input_fetch_field(hid, report->field[a], data); if (!list_empty(&report->field_entry_list)) { /* INPUT_REPORT, we have a priority list of fields */
The pointer fields is being assigned a value that is never read, the pointer is re-assigned a new value in for-loops that occur later on. The assignment is redundant and can be removed. Clean up clang scan build warning: drivers/hid/hid-core.c:1665:30: warning: Although the value stored to 'field' is used in the enclosing expression, the value is never actually read from 'field' [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)