| Message ID | 20220529132638.13420-2-danilokrummrich@dk-develop.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | ef17936654043829ac527a2e0483d944eaba30aa |
| Headers | show |
| Series | [RESEND,v3,1/2] dt-bindings: ps2-gpio: convert binding to json-schema | expand |
On Sun, May 29, 2022 at 3:26 PM Danilo Krummrich <danilokrummrich@dk-develop.de> wrote: > The PS/2 bus defines data and clock line to be open drain, this should > be reflected in the gpio flags set in the binding. > > Especially, this is important since the clock line sometimes is driven > by the host while being used as interrupt source. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Sun, 29 May 2022 15:26:38 +0200, Danilo Krummrich wrote: > The PS/2 bus defines data and clock line to be open drain, this should > be reflected in the gpio flags set in the binding. > > Especially, this is important since the clock line sometimes is driven > by the host while being used as interrupt source. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de> > --- > .../devicetree/bindings/serio/ps2-gpio.yaml | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/serio/ps2-gpio.yaml b/Documentation/devicetree/bindings/serio/ps2-gpio.yaml index 304132fd30c5..a63d9172346f 100644 --- a/Documentation/devicetree/bindings/serio/ps2-gpio.yaml +++ b/Documentation/devicetree/bindings/serio/ps2-gpio.yaml @@ -15,12 +15,18 @@ properties: data-gpios: description: - the gpio used for the data signal + the gpio used for the data signal - this should be flagged as + active high using open drain with (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN) + from <dt-bindings/gpio/gpio.h> since the signal is open drain by + definition maxItems: 1 clk-gpios: description: - the gpio used for the clock signal + the gpio used for the clock signal - this should be flagged as + active high using open drain with (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN) + from <dt-bindings/gpio/gpio.h> since the signal is open drain by + definition maxItems: 1 interrupts: @@ -52,7 +58,7 @@ examples: compatible = "ps2-gpio"; interrupt-parent = <&gpio>; interrupts = <23 IRQ_TYPE_EDGE_FALLING>; - data-gpios = <&gpio 24 GPIO_ACTIVE_HIGH>; - clk-gpios = <&gpio 23 GPIO_ACTIVE_HIGH>; + data-gpios = <&gpio 24 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; + clk-gpios = <&gpio 23 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; write-enable; };