| Message ID | 20221117190507.87535-2-linmengbo0689@protonmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | fade5a92931c241be5b7e185d946205cfdfcb26f |
| Headers | show |
| Series | Input: cyttsp5 - add vddio regulator | expand |
On 17/11/2022 20:05, Lin, Meng-Bo wrote: > The Samsung touchscreen controllers are often used with external pull-up Samsung or Cypress? > for the interrupt line and the I2C lines, so we might need to enable > a regulator to bring the lines into usable state. Otherwise, this might > cause spurious interrupts and reading from I2C will fail. > > Document support for a "vddio-supply" that is enabled by the cyttsp5 > driver so that the regulator gets enabled when needed. > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 18 Nov 2022, at 5:05 AM, Lin, Meng-Bo wrote: > The Samsung touchscreen controllers are often used with external pull-up > for the interrupt line and the I2C lines, so we might need to enable > a regulator to bring the lines into usable state. Otherwise, this might > cause spurious interrupts and reading from I2C will fail. > > Document support for a "vddio-supply" that is enabled by the cyttsp5 > driver so that the regulator gets enabled when needed. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> Reviewed-by: Alistair Francis <alistair@alistair23.me> > --- > .../devicetree/bindings/input/touchscreen/cypress,tt21000.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > index 1959ec394768..869a9bdd962f 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > @@ -34,6 +34,9 @@ properties: > vdd-supply: > description: Regulator for voltage. > > + vddio-supply: > + description: Optional Regulator for I/O voltage. > + > reset-gpios: > maxItems: 1 > > -- > 2.30.2 > > >
diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml index 1959ec394768..869a9bdd962f 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml @@ -34,6 +34,9 @@ properties: vdd-supply: description: Regulator for voltage. + vddio-supply: + description: Optional Regulator for I/O voltage. + reset-gpios: maxItems: 1
The Samsung touchscreen controllers are often used with external pull-up for the interrupt line and the I2C lines, so we might need to enable a regulator to bring the lines into usable state. Otherwise, this might cause spurious interrupts and reading from I2C will fail. Document support for a "vddio-supply" that is enabled by the cyttsp5 driver so that the regulator gets enabled when needed. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> --- .../devicetree/bindings/input/touchscreen/cypress,tt21000.yaml | 3 +++ 1 file changed, 3 insertions(+)