| Message ID | 20221125102536.3092713-1-zengheng4@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 53ffa6a9f83b2170c60591da1ead8791d5a42e81 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: amd_sfh: Add check for dma_alloc_coherent() | expand |
diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_client.c b/drivers/hid/amd-sfh-hid/amd_sfh_client.c index 8275bba63611..ab125f79408f 100644 --- a/drivers/hid/amd-sfh-hid/amd_sfh_client.c +++ b/drivers/hid/amd-sfh-hid/amd_sfh_client.c @@ -237,6 +237,10 @@ int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata) in_data->sensor_virt_addr[i] = dma_alloc_coherent(dev, sizeof(int) * 8, &cl_data->sensor_dma_addr[i], GFP_KERNEL); + if (!in_data->sensor_virt_addr[i]) { + rc = -ENOMEM; + goto cleanup; + } cl_data->sensor_sts[i] = SENSOR_DISABLED; cl_data->sensor_requested_cnt[i] = 0; cl_data->cur_hid_dev = i;
Since the dma_alloc_coherent() may return NULL, the pointer returned needs to be checked to avoid null-poineter dereference. Fixes: 4b2c53d93a4b ("SFH:Transport Driver to add support of AMD Sensor Fusion Hub (SFH)") Signed-off-by: Zeng Heng <zengheng4@huawei.com> --- drivers/hid/amd-sfh-hid/amd_sfh_client.c | 4 ++++ 1 file changed, 4 insertions(+)