| Message ID | 20230530141628.21290-1-stuart.a.hayhurst@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [1/1] HID: logitech-hidpp: Add USB and Bluetooth IDs for the Logitech G915 TKL Keyboard | expand |
On Tue, 2023-05-30 at 15:16 +0100, Stuart Hayhurst wrote: > Adds the USB and Bluetooth IDs for the Logitech G915 TKL keyboard, > for device detection > For this device, this provides battery reporting on top of hid- > generic > > Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com> You can add my: Reviewed-by: Bastien Nocera <hadess@hadess.net> to the v2 patch that you should send, otherwise the tree maintainers will get confused. Cheers > --- > drivers/hid/hid-logitech-hidpp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid- > logitech-hidpp.c > index b2cd7527de19..28761272afe5 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -4403,6 +4403,8 @@ static const struct hid_device_id > hidpp_devices[] = { > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) }, > { /* Logitech G903 Hero Gaming Mouse over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) }, > + { /* Logitech G915 TKL Keyboard over USB */ > + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC343) }, > { /* Logitech G920 Wheel over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, > USB_DEVICE_ID_LOGITECH_G920_WHEEL), > .driver_data = HIDPP_QUIRK_CLASS_G920 | > HIDPP_QUIRK_FORCE_OUTPUT_REPORTS}, > @@ -4418,6 +4420,8 @@ static const struct hid_device_id > hidpp_devices[] = { > { /* MX5500 keyboard over Bluetooth */ > HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb30b), > .driver_data = HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS }, > + { /* Logitech G915 TKL keyboard over Bluetooth */ > + HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb35f) }, > { /* M-RCQ142 V470 Cordless Laser Mouse over Bluetooth */ > HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb008) }, > { /* MX Master mouse over Bluetooth */
Oops, didn't realise it needed a v2, sorry. Thanks, Stuart On Tue, May 30, 2023 at 3:33 PM Bastien Nocera <hadess@hadess.net> wrote: > > On Tue, 2023-05-30 at 15:16 +0100, Stuart Hayhurst wrote: > > Adds the USB and Bluetooth IDs for the Logitech G915 TKL keyboard, > > for device detection > > For this device, this provides battery reporting on top of hid- > > generic > > > > Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com> > > You can add my: > > Reviewed-by: Bastien Nocera <hadess@hadess.net> > > to the v2 patch that you should send, otherwise the tree maintainers > will get confused. > > Cheers > > > --- > > drivers/hid/hid-logitech-hidpp.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid- > > logitech-hidpp.c > > index b2cd7527de19..28761272afe5 100644 > > --- a/drivers/hid/hid-logitech-hidpp.c > > +++ b/drivers/hid/hid-logitech-hidpp.c > > @@ -4403,6 +4403,8 @@ static const struct hid_device_id > > hidpp_devices[] = { > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) }, > > { /* Logitech G903 Hero Gaming Mouse over USB */ > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) }, > > + { /* Logitech G915 TKL Keyboard over USB */ > > + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC343) }, > > { /* Logitech G920 Wheel over USB */ > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, > > USB_DEVICE_ID_LOGITECH_G920_WHEEL), > > .driver_data = HIDPP_QUIRK_CLASS_G920 | > > HIDPP_QUIRK_FORCE_OUTPUT_REPORTS}, > > @@ -4418,6 +4420,8 @@ static const struct hid_device_id > > hidpp_devices[] = { > > { /* MX5500 keyboard over Bluetooth */ > > HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb30b), > > .driver_data = HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS }, > > + { /* Logitech G915 TKL keyboard over Bluetooth */ > > + HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb35f) }, > > { /* M-RCQ142 V470 Cordless Laser Mouse over Bluetooth */ > > HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb008) }, > > { /* MX Master mouse over Bluetooth */ >
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index b2cd7527de19..28761272afe5 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -4403,6 +4403,8 @@ static const struct hid_device_id hidpp_devices[] = { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) }, { /* Logitech G903 Hero Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) }, + { /* Logitech G915 TKL Keyboard over USB */ + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC343) }, { /* Logitech G920 Wheel over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL), .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS}, @@ -4418,6 +4420,8 @@ static const struct hid_device_id hidpp_devices[] = { { /* MX5500 keyboard over Bluetooth */ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb30b), .driver_data = HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS }, + { /* Logitech G915 TKL keyboard over Bluetooth */ + HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb35f) }, { /* M-RCQ142 V470 Cordless Laser Mouse over Bluetooth */ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb008) }, { /* MX Master mouse over Bluetooth */
Adds the USB and Bluetooth IDs for the Logitech G915 TKL keyboard, for device detection For this device, this provides battery reporting on top of hid-generic Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com> --- drivers/hid/hid-logitech-hidpp.c | 4 ++++ 1 file changed, 4 insertions(+)