| Message ID | 20230602140948.2138668-2-yangcong5@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add ili9882t timing | expand |
On 02/06/2023 16:09, Cong Yang wrote: > Add an ilitek touch screen chip ili9882t. > > Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. There is no way this would work and if you test you will see error msg. Feel free to ping if message is unclear. > --- > .../bindings/input/elan,ekth6915.yaml | 36 ++++++++++++++----- > 1 file changed, 27 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > index 05e6f2df604c..73e94cb6c4e0 100644 > --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > @@ -15,11 +15,15 @@ description: > > properties: > compatible: > - items: > - - const: elan,ekth6915 > + oneOf: It's not oneOf. Just enum > + - enum: > + - elan,ekth6915 > + - ilitek,ili9882t > > reg: > - const: 0x10 > + enum: > + - 0x10 > + - 0x41 > > interrupts: > maxItems: 1 > @@ -29,17 +33,31 @@ properties: > > vcc33-supply: > description: The 3.3V supply to the touchscreen. > + If using ili9882t then this supply will not be needed. Are you sure these are compatible devices then? What does it mean "not needed"? Is the pin there or is not? > > vccio-supply: > description: > The IO supply to the touchscreen. Need not be specified if this is the > same as the 3.3V supply. > - > -required: > - - compatible > - - reg > - - interrupts > - - vcc33-supply > + If using ili9882t, the IO supply is required. > + > + required: NAK. Really. Test patches before sending. Best regards, Krzysztof
On Fri, 02 Jun 2023 22:09:47 +0800, Cong Yang wrote: > Add an ilitek touch screen chip ili9882t. > > Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> > --- > .../bindings/input/elan,ekth6915.yaml | 36 ++++++++++++++----- > 1 file changed, 27 insertions(+), 9 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/input/elan,ekth6915.yaml:20:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/elan,ekth6915.yaml: properties:required: ['compatible', 'reg', 'interrupts', 'vcc33-supply'] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/elan,ekth6915.yaml: properties: 'required' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'} hint: A json-schema keyword was found instead of a DT property name. from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/elan,ekth6915.yaml: ignoring, error in schema: properties: required Documentation/devicetree/bindings/input/elan,ekth6915.example.dtb: /example-0/i2c/touchscreen@10: failed to match any schema with compatible: ['elan,ekth6915'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230602140948.2138668-2-yangcong5@huaqin.corp-partner.google.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi,Krzysztof, Thanks for Krzysztof.Sorry, I didn't run `make dt_binding_check. I will check before sending V2 patch. On Fri, Jun 2, 2023 at 10:19 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 02/06/2023 16:09, Cong Yang wrote: > > Add an ilitek touch screen chip ili9882t. > > > > Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. > > There is no way this would work and if you test you will see error msg. > Feel free to ping if message is unclear. > > > --- > > .../bindings/input/elan,ekth6915.yaml | 36 ++++++++++++++----- > > 1 file changed, 27 insertions(+), 9 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > index 05e6f2df604c..73e94cb6c4e0 100644 > > --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > @@ -15,11 +15,15 @@ description: > > > > properties: > > compatible: > > - items: > > - - const: elan,ekth6915 > > + oneOf: > > It's not oneOf. Just enum Done,thanks. > > > + - enum: > > + - elan,ekth6915 > > + - ilitek,ili9882t > > > > reg: > > - const: 0x10 > > + enum: > > + - 0x10 > > + - 0x41 > > > > interrupts: > > maxItems: 1 > > @@ -29,17 +33,31 @@ properties: > > > > vcc33-supply: > > description: The 3.3V supply to the touchscreen. > > + If using ili9882t then this supply will not be needed. > > Are you sure these are compatible devices then? What does it mean "not > needed"? Is the pin there or is not? Yes,ili9882t this touch ic not needed 3.3V supply,this pin does not exist. > > > > > vccio-supply: > > description: > > The IO supply to the touchscreen. Need not be specified if this is the > > same as the 3.3V supply. > > - > > -required: > > - - compatible > > - - reg > > - - interrupts > > - - vcc33-supply > > + If using ili9882t, the IO supply is required. > > + > > + required: > > NAK. Really. Test patches before sending. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml index 05e6f2df604c..73e94cb6c4e0 100644 --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml @@ -15,11 +15,15 @@ description: properties: compatible: - items: - - const: elan,ekth6915 + oneOf: + - enum: + - elan,ekth6915 + - ilitek,ili9882t reg: - const: 0x10 + enum: + - 0x10 + - 0x41 interrupts: maxItems: 1 @@ -29,17 +33,31 @@ properties: vcc33-supply: description: The 3.3V supply to the touchscreen. + If using ili9882t then this supply will not be needed. vccio-supply: description: The IO supply to the touchscreen. Need not be specified if this is the same as the 3.3V supply. - -required: - - compatible - - reg - - interrupts - - vcc33-supply + If using ili9882t, the IO supply is required. + + required: + - compatible + - reg + - interrupts + - vcc33-supply + +if: + properties: + compatible: + contains: + const: ilitek,ili9882t +then: + required: + - compatible + - reg + - interrupts + - vccio-supply additionalProperties: false
Add an ilitek touch screen chip ili9882t. Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> --- .../bindings/input/elan,ekth6915.yaml | 36 ++++++++++++++----- 1 file changed, 27 insertions(+), 9 deletions(-)