| Message ID | 20231203032431.30277-2-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a9f68ffe1170ca4bc17ab29067d806a354a026e0 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | Fixes for spurious wakeups on some Lenovo laptops | expand |
On Sat, 2 Dec 2023, Mario Limonciello wrote: > Users have reported problems with recent Lenovo laptops that contain > an IDEA5002 I2C HID device. Reports include fans turning on and > running even at idle and spurious wakeups from suspend. > > Presumably in the Windows ecosystem there is an application that > uses the HID device. Maybe that puts it into a lower power state so > it doesn't cause spurious events. > > This device doesn't serve any functional purpose in Linux as nothing > interacts with it so blacklist it from being probed. This will > prevent the GPIO driver from setting up the GPIO and the spurious > interrupts and wake events will not occur. > > Cc: stable@vger.kernel.org # 6.1 > Reported-and-tested-by: Marcus Aram <marcus+oss@oxar.nl> > Reported-and-tested-by: Mark Herbert <mark.herbert42@gmail.com> > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2812 > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/hid/i2c-hid/i2c-hid-acpi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/hid/i2c-hid/i2c-hid-acpi.c b/drivers/hid/i2c-hid/i2c-hid-acpi.c > index ac918a9ea8d3..1b49243adb16 100644 > --- a/drivers/hid/i2c-hid/i2c-hid-acpi.c > +++ b/drivers/hid/i2c-hid/i2c-hid-acpi.c > @@ -40,6 +40,11 @@ static const struct acpi_device_id i2c_hid_acpi_blacklist[] = { > * ICN8505 controller, has a _CID of PNP0C50 but is not HID compatible. > */ > { "CHPN0001" }, > + /* > + * The IDEA5002 ACPI device causes high interrupt usage and spurious > + * wakeups from suspend. > + */ > + { "IDEA5002" }, Applied to hid.git#for-6.7/upstream-fixes. Thanks,
diff --git a/drivers/hid/i2c-hid/i2c-hid-acpi.c b/drivers/hid/i2c-hid/i2c-hid-acpi.c index ac918a9ea8d3..1b49243adb16 100644 --- a/drivers/hid/i2c-hid/i2c-hid-acpi.c +++ b/drivers/hid/i2c-hid/i2c-hid-acpi.c @@ -40,6 +40,11 @@ static const struct acpi_device_id i2c_hid_acpi_blacklist[] = { * ICN8505 controller, has a _CID of PNP0C50 but is not HID compatible. */ { "CHPN0001" }, + /* + * The IDEA5002 ACPI device causes high interrupt usage and spurious + * wakeups from suspend. + */ + { "IDEA5002" }, { } };
Users have reported problems with recent Lenovo laptops that contain an IDEA5002 I2C HID device. Reports include fans turning on and running even at idle and spurious wakeups from suspend. Presumably in the Windows ecosystem there is an application that uses the HID device. Maybe that puts it into a lower power state so it doesn't cause spurious events. This device doesn't serve any functional purpose in Linux as nothing interacts with it so blacklist it from being probed. This will prevent the GPIO driver from setting up the GPIO and the spurious interrupts and wake events will not occur. Cc: stable@vger.kernel.org # 6.1 Reported-and-tested-by: Marcus Aram <marcus+oss@oxar.nl> Reported-and-tested-by: Mark Herbert <mark.herbert42@gmail.com> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2812 Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/hid/i2c-hid/i2c-hid-acpi.c | 5 +++++ 1 file changed, 5 insertions(+)