| Message ID | 20240407022804.27081-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7e642aef8937dda15ad95e42418d85e73c76b47d |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: Remove the unused variable minor | expand |
On Sun, 7 Apr 2024, Jiapeng Chong wrote: > Variable minor is not effectively used, so delete it. > > drivers/hid/hid-winwing.c:123:15: warning: variable 'minor' set but not used. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8705 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> I've added Fixes: 266c990debad2 ("HID: Add WinWing Orion2 throttle support") CCed Ivan here, and applied. Thanks,
diff --git a/drivers/hid/hid-winwing.c b/drivers/hid/hid-winwing.c index d895c82a541d..0e224d1a6466 100644 --- a/drivers/hid/hid-winwing.c +++ b/drivers/hid/hid-winwing.c @@ -120,7 +120,6 @@ static int winwing_init_led(struct hid_device *hdev, static int winwing_probe(struct hid_device *hdev, const struct hid_device_id *id) { - unsigned int minor; int ret; ret = hid_parse(hdev); @@ -135,8 +134,6 @@ static int winwing_probe(struct hid_device *hdev, return ret; } - minor = ((struct hidraw *) hdev->hidraw)->minor; - return 0; }
Variable minor is not effectively used, so delete it. drivers/hid/hid-winwing.c:123:15: warning: variable 'minor' set but not used. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8705 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/hid/hid-winwing.c | 3 --- 1 file changed, 3 deletions(-)