| Message ID | 20240515144943.678260-1-matthijs@stdin.nl (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Input: ilitek_ts_i2c: Use gpiod_set_value_cansleep() | expand |
Hi Matthijs, On Wed, May 15, 2024 at 04:49:44PM +0200, Matthijs Kooijman wrote: > Use gpiod_set_value_cansleep in the ilitek_reset function (called only > from ilitek_ts_i2c_probe and ilitek_resume). > > Without this change, the driver may print a warning if the reset pin is > connected to a GPIO chip which can sleep (e.g. a GPIO expander): > > WARNING: CPU: 1 PID: 578 at gpiod_set_value+0x5c/0xd0 > > This commit is modeled after commit 7c977019c53ed (leds: lp55xx: Use > gpiod_set_value_cansleep(), 2023-09-18) > > Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl> > --- > drivers/input/touchscreen/ilitek_ts_i2c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/ilitek_ts_i2c.c b/drivers/input/touchscreen/ilitek_ts_i2c.c > index fc4e39b6651a4..236c332de6cdc 100644 > --- a/drivers/input/touchscreen/ilitek_ts_i2c.c > +++ b/drivers/input/touchscreen/ilitek_ts_i2c.c > @@ -391,9 +391,9 @@ static const struct ilitek_protocol_map ptl_func_map[] = { > static void ilitek_reset(struct ilitek_ts_data *ts, int delay) > { > if (ts->reset_gpio) { > - gpiod_set_value(ts->reset_gpio, 1); > + gpiod_set_value_cansleep(ts->reset_gpio, 1); > mdelay(10); > - gpiod_set_value(ts->reset_gpio, 0); > + gpiod_set_value_cansleep(ts->reset_gpio, 0); > mdelay(delay); While we are changing GPIO to the sleeping variant we should also change these mdelays to usleep_range() and msleep() respectively. Thanks.
diff --git a/drivers/input/touchscreen/ilitek_ts_i2c.c b/drivers/input/touchscreen/ilitek_ts_i2c.c index fc4e39b6651a4..236c332de6cdc 100644 --- a/drivers/input/touchscreen/ilitek_ts_i2c.c +++ b/drivers/input/touchscreen/ilitek_ts_i2c.c @@ -391,9 +391,9 @@ static const struct ilitek_protocol_map ptl_func_map[] = { static void ilitek_reset(struct ilitek_ts_data *ts, int delay) { if (ts->reset_gpio) { - gpiod_set_value(ts->reset_gpio, 1); + gpiod_set_value_cansleep(ts->reset_gpio, 1); mdelay(10); - gpiod_set_value(ts->reset_gpio, 0); + gpiod_set_value_cansleep(ts->reset_gpio, 0); mdelay(delay); } }
Use gpiod_set_value_cansleep in the ilitek_reset function (called only from ilitek_ts_i2c_probe and ilitek_resume). Without this change, the driver may print a warning if the reset pin is connected to a GPIO chip which can sleep (e.g. a GPIO expander): WARNING: CPU: 1 PID: 578 at gpiod_set_value+0x5c/0xd0 This commit is modeled after commit 7c977019c53ed (leds: lp55xx: Use gpiod_set_value_cansleep(), 2023-09-18) Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl> --- drivers/input/touchscreen/ilitek_ts_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)