| Message ID | 20240531085559.129085-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 09bae5876dde05410e62145f7e4c3be39011efff |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: nintendo: Remove some unused functions | expand |
On Fri, 31 May 2024, Jiapeng Chong wrote: > These functions are defined in the hid-nintendo.c file, but not > called elsewhere, so delete these unused functions. > > drivers/hid/hid-nintendo.c:672:20: warning: unused function 'joycon_device_is_procon'. > drivers/hid/hid-nintendo.c:682:20: warning: unused function 'joycon_device_is_snescon'. > drivers/hid/hid-nintendo.c:687:20: warning: unused function 'joycon_device_is_gencon'. > drivers/hid/hid-nintendo.c:692:20: warning: unused function 'joycon_device_is_n64con'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9265 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Applied, thanks.
diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c index b4a97803eca3..be7f7e47d65f 100644 --- a/drivers/hid/hid-nintendo.c +++ b/drivers/hid/hid-nintendo.c @@ -658,7 +658,6 @@ struct joycon_ctlr { (ctlr->ctlr_type == JOYCON_CTLR_TYPE_JCR || \ ctlr->ctlr_type == JOYCON_CTLR_TYPE_PRO) - /* * Controller device helpers * @@ -669,31 +668,11 @@ struct joycon_ctlr { * These helpers are most useful early during the HID probe or in conjunction * with the capability helpers below. */ -static inline bool joycon_device_is_procon(struct joycon_ctlr *ctlr) -{ - return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_PROCON; -} - static inline bool joycon_device_is_chrggrip(struct joycon_ctlr *ctlr) { return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_CHRGGRIP; } -static inline bool joycon_device_is_snescon(struct joycon_ctlr *ctlr) -{ - return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_SNESCON; -} - -static inline bool joycon_device_is_gencon(struct joycon_ctlr *ctlr) -{ - return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_GENCON; -} - -static inline bool joycon_device_is_n64con(struct joycon_ctlr *ctlr) -{ - return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_N64CON; -} - /* * Controller type helpers *
These functions are defined in the hid-nintendo.c file, but not called elsewhere, so delete these unused functions. drivers/hid/hid-nintendo.c:672:20: warning: unused function 'joycon_device_is_procon'. drivers/hid/hid-nintendo.c:682:20: warning: unused function 'joycon_device_is_snescon'. drivers/hid/hid-nintendo.c:687:20: warning: unused function 'joycon_device_is_gencon'. drivers/hid/hid-nintendo.c:692:20: warning: unused function 'joycon_device_is_n64con'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9265 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/hid/hid-nintendo.c | 21 --------------------- 1 file changed, 21 deletions(-)