| Message ID | 20240619122703.2081476-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7c7b1be19b228b450c2945ec379d7fc6bfef9852 |
| Headers | show |
| Series | [1/1] Input: ads7846 - Use spi_device_id table | expand |
On Wed, Jun 19, 2024 at 02:27:02PM +0200, Alexander Stein wrote: > As the driver supports more devices over time the single MODULE_ALIAS > is complete and raises several warnings: > SPI driver ads7846 has no spi_device_id for ti,tsc2046 > SPI driver ads7846 has no spi_device_id for ti,ads7843 > SPI driver ads7846 has no spi_device_id for ti,ads7845 > SPI driver ads7846 has no spi_device_id for ti,ads7873 > > Fix this by adding a spi_device_id table and removing the manual > MODULE_ALIAS. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Applied, thank you.
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index d2bbb436a77df..4d13db13b9e57 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c @@ -1111,6 +1111,16 @@ static const struct of_device_id ads7846_dt_ids[] = { }; MODULE_DEVICE_TABLE(of, ads7846_dt_ids); +static const struct spi_device_id ads7846_spi_ids[] = { + { "tsc2046", 7846 }, + { "ads7843", 7843 }, + { "ads7845", 7845 }, + { "ads7846", 7846 }, + { "ads7873", 7873 }, + { }, +}; +MODULE_DEVICE_TABLE(spi, ads7846_spi_ids); + static const struct ads7846_platform_data *ads7846_get_props(struct device *dev) { struct ads7846_platform_data *pdata; @@ -1386,10 +1396,10 @@ static struct spi_driver ads7846_driver = { }, .probe = ads7846_probe, .remove = ads7846_remove, + .id_table = ads7846_spi_ids, }; module_spi_driver(ads7846_driver); MODULE_DESCRIPTION("ADS7846 TouchScreen Driver"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("spi:ads7846");
As the driver supports more devices over time the single MODULE_ALIAS is complete and raises several warnings: SPI driver ads7846 has no spi_device_id for ti,tsc2046 SPI driver ads7846 has no spi_device_id for ti,ads7843 SPI driver ads7846 has no spi_device_id for ti,ads7845 SPI driver ads7846 has no spi_device_id for ti,ads7873 Fix this by adding a spi_device_id table and removing the manual MODULE_ALIAS. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/input/touchscreen/ads7846.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)