| Message ID | 20240709-md-drivers-hid-v2-1-67faf2f2ec90@quicinc.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 5bd8d7071e54580a20268ffb661dafd06e1d557e |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [v2] HID: add more missing MODULE_DESCRIPTION() macros | expand |
On Tue, 09 Jul 2024 14:39:11 -0700, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-holtek-mouse.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ite.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kensington.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-keytouch.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kye.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lcpower.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lenovo.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-winwing.o > > [...] Applied to hid/hid.git (for-6.11/module-description), thanks! [1/1] HID: add more missing MODULE_DESCRIPTION() macros https://git.kernel.org/hid/hid/c/5bd8d7071e54 Cheers,
diff --git a/drivers/hid/hid-holtek-mouse.c b/drivers/hid/hid-holtek-mouse.c index 7c907939bfae..343730c28e2d 100644 --- a/drivers/hid/hid-holtek-mouse.c +++ b/drivers/hid/hid-holtek-mouse.c @@ -110,4 +110,5 @@ static struct hid_driver holtek_mouse_driver = { }; module_hid_driver(holtek_mouse_driver); +MODULE_DESCRIPTION("HID driver for Holtek gaming mice"); MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-ite.c b/drivers/hid/hid-ite.c index 75ebfcf31889..6a7281bc27c9 100644 --- a/drivers/hid/hid-ite.c +++ b/drivers/hid/hid-ite.c @@ -141,4 +141,5 @@ static struct hid_driver ite_driver = { module_hid_driver(ite_driver); MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>"); +MODULE_DESCRIPTION("HID driver for some ITE \"special\" devices"); MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-kensington.c b/drivers/hid/hid-kensington.c index b31f7f431a3f..99e79b42047c 100644 --- a/drivers/hid/hid-kensington.c +++ b/drivers/hid/hid-kensington.c @@ -46,4 +46,5 @@ static struct hid_driver ks_driver = { }; module_hid_driver(ks_driver); +MODULE_DESCRIPTION("HID driver for Kensigton Slimblade Trackball"); MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-keytouch.c b/drivers/hid/hid-keytouch.c index 73bf8642dfe3..a972943baaea 100644 --- a/drivers/hid/hid-keytouch.c +++ b/drivers/hid/hid-keytouch.c @@ -48,5 +48,6 @@ static struct hid_driver keytouch_driver = { }; module_hid_driver(keytouch_driver); +MODULE_DESCRIPTION("HID driver for Keytouch devices not fully compliant with HID standard"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Jiri Kosina"); diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c index 70ceb9437332..ca2ba3da2458 100644 --- a/drivers/hid/hid-kye.c +++ b/drivers/hid/hid-kye.c @@ -671,4 +671,5 @@ static struct hid_driver kye_driver = { }; module_hid_driver(kye_driver); +MODULE_DESCRIPTION("HID driver for Kye/Genius devices not fully compliant with HID standard"); MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-lcpower.c b/drivers/hid/hid-lcpower.c index 8acd3ee5ada5..58953d11ded7 100644 --- a/drivers/hid/hid-lcpower.c +++ b/drivers/hid/hid-lcpower.c @@ -53,4 +53,5 @@ static struct hid_driver ts_driver = { }; module_hid_driver(ts_driver); +MODULE_DESCRIPTION("HID driver for LC Power Model RC1000MCE"); MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index e6b2ae68b8fb..e5e72aa5260a 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -1442,4 +1442,5 @@ static struct hid_driver lenovo_driver = { }; module_hid_driver(lenovo_driver); +MODULE_DESCRIPTION("HID driver for IBM/Lenovo"); MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-winwing.c b/drivers/hid/hid-winwing.c index 0e224d1a6466..10a5d87ccb96 100644 --- a/drivers/hid/hid-winwing.c +++ b/drivers/hid/hid-winwing.c @@ -223,4 +223,5 @@ static struct hid_driver winwing_driver = { }; module_hid_driver(winwing_driver); +MODULE_DESCRIPTION("HID driver for WinWing Orion 2 throttle"); MODULE_LICENSE("GPL");
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-holtek-mouse.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ite.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kensington.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-keytouch.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kye.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lcpower.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lenovo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-winwing.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- The missing MODULE_DESCRIPTION() macros in drivers/hid were supposed to be fixed by: https://lore.kernel.org/all/20240604-md-hid-misc-v1-1-4f9560796f3c@quicinc.com/ I somehow failed to include some of the fixes, and I subsequently sent: https://lore.kernel.org/all/20240606-md-drivers-hid-v1-1-d6a5120b94cb@quicinc.com/ But then I confused myself and thought that second patch wasn't needed: https://lore.kernel.org/all/c777aad9-3b0a-43d3-9e6b-1e1807df61a8@quicinc.com/ But then realized it was actually needed: https://lore.kernel.org/all/50c97718-b304-4eb5-9bb0-53ff32ccf185@quicinc.com/ Since it hasn't landed in linux-next, posting a renamed version so that it can hopefully be picked up in time for the 6.11 merge window. --- Changes in v2: - Modified the subject to differentiate it from the original patch - Link to v1: https://lore.kernel.org/r/20240606-md-drivers-hid-v1-1-d6a5120b94cb@quicinc.com --- drivers/hid/hid-holtek-mouse.c | 1 + drivers/hid/hid-ite.c | 1 + drivers/hid/hid-kensington.c | 1 + drivers/hid/hid-keytouch.c | 1 + drivers/hid/hid-kye.c | 1 + drivers/hid/hid-lcpower.c | 1 + drivers/hid/hid-lenovo.c | 1 + drivers/hid/hid-winwing.c | 1 + 8 files changed, 8 insertions(+) --- base-commit: 34afb82a3c67f869267a26f593b6f8fc6bf35905 change-id: 20240606-md-drivers-hid-42e9f9c85cd9